Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check licensing for the codebase; add appropriate license. #38

Closed
nathan-at-least opened this issue Jan 6, 2015 · 6 comments
Closed

Comments

@nathan-at-least
Copy link
Contributor

Issue by nathan-at-least
Tuesday Nov 25, 2014 at 21:17 GMT
Originally opened as Electric-Coin-Company/libzerocash#1


@daira
Copy link
Contributor

daira commented Jan 15, 2015

I notice that https://github.com/Electric-Coin-Company/zerocashd/blob/master/COPYING still has only "Copyright (c) 2009-2013 Bitcoin Developers".

@daira daira added this to the Public Announcement milestone Jan 15, 2015
@daira
Copy link
Contributor

daira commented Jan 15, 2015

@daira
Copy link
Contributor

daira commented Jan 15, 2015

Also each source file has its own copyright notice. sigh.

@daira
Copy link
Contributor

daira commented Jan 16, 2015

There is a script https://github.com/zcash/zcash/blob/zc.v0.11.2.latest/contrib/devtools/fix-copyright-headers.py that updates all the copyright headers to the current year. This is unfortunate because it means that if we change the headers, then there will be merge conflicts for every file each time we rebase after upstream has run the script.

What I would suggest is that we not change the copyright headers in our development and feature branches, but that each time we prepare a release, we run a version of fix-copyright-headers.py that fixes up the headers to say "Copyright (c) 2009-$CURRENTYEAR Bitcoin and Zcash Developers".

[Edit: updated URL and Zerocash -> Zcash.]

@daira
Copy link
Contributor

daira commented Jan 16, 2015

Oh wait, that may still not work legally. The problem is that anything we put in a github repo is a published work that someone could create a derived work of. So any Zerocash contributors that are not also "Bitcoin Developers" will not have copyright on the files they modified in a development or feature branch, if the copyright notice on a file is interpreted to override the ones in COPYING and README.md.

(It doesn't matter very much because the license is MIT, so it's not as though this makes much difference to what people can do with the code.)

@ebfull ebfull modified the milestones: DEPRECATED - Public Announcement, 1.0 Mar 15, 2016
@nathan-at-least nathan-at-least modified the milestones: 1.0, Consensus Feature Implementation Deadline Mar 28, 2016
@nathan-at-least nathan-at-least modified the milestones: Consensus Code Security Freeze, Consensus Feature Implementation Deadline Mar 29, 2016
@nathan-at-least nathan-at-least modified the milestones: Consensus Code Security Freeze, Temporary overflow Jul 14, 2016
@nathan-at-least nathan-at-least modified the milestones: Temporary overflow, Consensus Code Security Freeze Jul 14, 2016
@nathan-at-least nathan-at-least modified the milestones: z8 release - core audit freeze (excluding RPC), 1.0 Launch Jul 25, 2016
@nathan-at-least
Copy link
Contributor Author

This is similar to #3.

@zkbot zkbot closed this as completed in 5275df5 Oct 23, 2016
WaveringAna pushed a commit to WaveringAna/zclassic-addressindexing that referenced this issue Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants