Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blossom] Resolve interaction between ZIP 308 (Sprout to Sapling Migration) and shorter block times #4006

Closed
daira opened this issue May 10, 2019 · 3 comments
Labels
A-wallet Area: Wallet NU2-blossom Network upgrade: Blossom-specific tasks

Comments

@daira
Copy link
Contributor

daira commented May 10, 2019

ZIP 308 specifies that migration is done every 500 blocks; decide whether this needs to change as a result of ZIP 208 (Shorter Block Target Spacing).

@daira
Copy link
Contributor Author

daira commented May 10, 2019

One option is to simply leave it as-is, and accept that this will result in migrations occurring more frequently after Blossom activation.

The 3-hour window introduced in #3995 also needs to be reconsidered, based on whether we change the two-hour limit on block timestamp postdating.

@daira daira added the A-wallet Area: Wallet label May 10, 2019
@daira
Copy link
Contributor Author

daira commented Jan 14, 2020

The 3-hour window need not be changed because, according to the rationale in #3995 (comment), it only needs to be greater than the 2-hour limit on future-dated block timestamps, which did not change. (If we were to change that limit it would only be to decrease it.)

In any case, neither the 500-block interval nor the 3-hour window were changed in the implementation. However, I missed updating ZIPs 208 and 308, and will do that now.

@daira
Copy link
Contributor Author

daira commented Jan 21, 2020

ZIPs 208 and 308 have been updated in zcash/zips@20ebcf4

@daira daira closed this as completed Jan 21, 2020
@str4d str4d added NU2-blossom Network upgrade: Blossom-specific tasks and removed Blossom Goal labels Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-wallet Area: Wallet NU2-blossom Network upgrade: Blossom-specific tasks
Projects
None yet
Development

No branches or pull requests

2 participants