Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to ed25519-zebra 2.0.0 #4592

Closed
ebfull opened this issue Jul 7, 2020 · 1 comment · Fixed by #4594
Closed

Switch to ed25519-zebra 2.0.0 #4592

ebfull opened this issue Jul 7, 2020 · 1 comment · Fixed by #4594
Assignees
@nuttycom
Labels
E-good-first-issue Effort: Suitable for someone new to the codebase.
Milestone
Core Sprint 2020-27

Comments

@ebfull
Copy link
Contributor

ebfull commented Jul 7, 2020

Currently we bring in a fork of ed25519-zebra, but this fork can be replaced with the new 2.0.0 release of ed25519-zebra which has the same behavior.

Steps:

  1. Change the ./depends/packages/crate_ed25519_zebra.mk file to point to ed25519-zebra from crates.io.
  2. Update Cargo.toml to point to the crates.io version of ed25519-zebra version 2 or above.
  3. Remove the git branch source replacement logic from ./.cargo/config.offline as this is now obviated.
  4. Compile in online mode (CONFIGURE_FLAGS="--enable-online-rust" ./zcutil/build.sh -j8) to make updates to Cargo.lock
  5. Make sure your changes worked by compiling in offline mode.
@ebfull ebfull added the E-good-first-issue Effort: Suitable for someone new to the codebase. label Jul 7, 2020
@str4d
Copy link
Contributor

str4d commented Jul 7, 2020

Step 1 can be done using the vendorcrate.sh script in depends/packages.

@nuttycom nuttycom self-assigned this Jul 8, 2020
@nuttycom nuttycom mentioned this issue Jul 8, 2020
Merged
@zkbot zkbot closed this as completed in cf034d4 Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nuttycom nuttycom

Labels
E-good-first-issue Effort: Suitable for someone new to the codebase.
Projects
None yet
Milestone
Core Sprint 2020-27
Development

Successfully merging a pull request may close this issue.

Use ed25519-zebra from crates.io. nuttycom/zcash
3 participants
@nuttycom @ebfull @str4d