Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the zcashd -optimize-getheaders configuration option #5013

Open
LarryRuane opened this issue Feb 25, 2021 · 1 comment
Open

Deprecate the zcashd -optimize-getheaders configuration option #5013

LarryRuane opened this issue Feb 25, 2021 · 1 comment
Assignees

Comments

@LarryRuane
Copy link
Collaborator

PR #4624 improved initial block download (IBD) performance for release 4.3.0, but there was a small concern that the change could have bad side-effects (for example, cause IBD to stall). Purely as a defensive measure, in case a user ran into a problem with the change, that PR also added an option to disable the new behavior. The default was -optimize-getheaders (or -optimize-getheaders=1), that is, enable the improvement, but it could be disabled with -nooptimize-getheaders(or-optimize-getheaders=0`).

After another release or two, we'll be confident in the fix, and this option can be removed (just for clean-up). This ticket is to remind us to do that. It should probably be removed in 4.4.0 or 4.5.0.

@LarryRuane LarryRuane self-assigned this Feb 25, 2021
@daira
Copy link
Contributor

daira commented Jan 9, 2022

We should probably include this in 4.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants