Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate old address-related RPCs #5177

Closed
str4d opened this issue May 24, 2021 · 1 comment · Fixed by #5555
Closed

Deprecate old address-related RPCs #5177

str4d opened this issue May 24, 2021 · 1 comment · Fixed by #5555
Labels
A-rpc-interface Area: RPC interface

Comments

@str4d
Copy link
Contributor

str4d commented May 24, 2021

  • getnewaddress
    • UAs will generate P2PKH address components internally, from a key tree that is domain separated from any addresses that might be returned by this RPC.
  • z_getnewaddress
    • It has the semantics that each call generates a new spend authority for a new logical pool of funds.
    • Its name indicates it fetches a new address rather than a new key, which complicates address diversification.
    • It allows selecting a specific pool, but for UAs we won't be exposing that.
  • z_gettotalbalance
    • Deprecate the old fields (but keep them for now, including Orchard balances in "private")
    • API itself is fine (we will extend the dictionary output with new fields)
@str4d
Copy link
Contributor Author

str4d commented Dec 14, 2021

#5300 marks getnewaddress and z_getnewaddress as deprecated in their help text. We can close this issue once z_gettotalbalance is also updated, and the deprecation is added to the release notes (which we can do in #5419 once we're ready to merge it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc-interface Area: RPC interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants