Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for funding z_sendmany from a UA account #5185

Closed
str4d opened this issue May 24, 2021 · 2 comments
Closed

Add support for funding z_sendmany from a UA account #5185

str4d opened this issue May 24, 2021 · 2 comments
Assignees
Labels
A-rpc-interface Area: RPC interface A-wallet Area: Wallet A-wallet-change Area: Change handling within the wallet S-committed Status: Planned work in a sprint

Comments

@str4d
Copy link
Contributor

str4d commented May 24, 2021

z_sendmany won't take an account number as the first argument (that would complicate the RPC UX too much); instead allow it to take a UA as the fromaddress.

  • Errors if fromaddress is a UA that does not correspond to any existing account in the wallet.
  • If a UA with multiple components is provided as the fromaddress, take funds only from one pool; the most recent one that has enough funds (if any).
  • Add an argument flag that indicates that no amounts should be revealed as part of the transfer.
    • Errors if e.g. user specifies recipients from multiple pools.
  • Change is handled as-currently, i.e. returned to the first involved address from which the funds are taken.
    • This means that if a UA has Sapling and Orchard, with sufficient funds in Sapling, the change goes back to the Sapling receiver.
@nuttycom
Copy link
Contributor

This will be resolved by #5469

@str4d
Copy link
Contributor Author

str4d commented Feb 8, 2022

Closed by #5469, merged into #5419.

@str4d str4d closed this as completed Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc-interface Area: RPC interface A-wallet Area: Wallet A-wallet-change Area: Change handling within the wallet S-committed Status: Planned work in a sprint
Projects
None yet
Development

No branches or pull requests

4 participants