-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
z_sendmany
should lock notes being spent
#5654
Labels
Comments
sellout
added a commit
to sellout/zcash
that referenced
this issue
Nov 11, 2022
This fixes an RPC test failure that tests specifically for this with z_shieldcoinbase. This also exposed an issue where an overly-high fee resulted in a negative Payment causing an exception too deep. Added an assert when creating a Payment and guarded against it for z_shieldcoinbase. Fixes zcash#2621 and zcash#5654 (but does not handle Orchard locking, which is tracked in a separate issue).
sellout
added a commit
to sellout/zcash
that referenced
this issue
Jan 12, 2023
This fixes an RPC test failure that tests specifically for this with z_shieldcoinbase. This also exposed an issue where an overly-high fee resulted in a negative Payment causing an exception too deep. Added an assert when creating a Payment and guarded against it for z_shieldcoinbase. Fixes zcash#2621 and zcash#5654 (but does not handle Orchard locking, which is tracked in a separate issue).
sellout
added a commit
to sellout/zcash
that referenced
this issue
Feb 1, 2023
This fixes an RPC test failure that tests specifically for this with z_shieldcoinbase. This also exposed an issue where an overly-high fee resulted in a negative Payment causing an exception too deep. Added an assert when creating a Payment and guarded against it for z_shieldcoinbase. Fixes zcash#2621 and zcash#5654 (but does not handle Orchard locking, which is tracked in a separate issue).
This was referenced Feb 1, 2023
sellout
added a commit
to sellout/zcash
that referenced
this issue
Mar 13, 2023
This fixes an RPC test failure that tests specifically for this with z_shieldcoinbase. This also exposed an issue where an overly-high fee resulted in a negative Payment causing an exception too deep. Added an assert when creating a Payment and guarded against it for z_shieldcoinbase. Fixes zcash#2621 and zcash#5654 (but does not handle Orchard locking, which is tracked in a separate issue).
sellout
added a commit
to sellout/zcash
that referenced
this issue
Mar 29, 2023
This fixes an RPC test failure that tests specifically for this with z_shieldcoinbase. This also exposed an issue where an overly-high fee resulted in a negative Payment causing an exception too deep. Added an assert when creating a Payment and guarded against it for z_shieldcoinbase. Fixes zcash#2621 and zcash#5654 (but does not handle Orchard locking, which is tracked in a separate issue).
Fixed by #6408. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#3106 added note locking for
z_mergetoaddress
(including Sapling notes in #3496); we also need it forz_sendmany
.See #2621 for locking transparent UTXOs in
z_sendmany
.See #5568 to add support for locking Orchard notes.
The text was updated successfully, but these errors were encountered: