Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a regression test to guard against recurrence of #5819 #5822

Open
nuttycom opened this issue Apr 5, 2022 · 1 comment
Open

Add a regression test to guard against recurrence of #5819 #5822

nuttycom opened this issue Apr 5, 2022 · 1 comment
Labels
A-testing Area: Tests and testing infrastructure I-regression This is a regression, i.e. something that previously worked but now does not due to a change we made

Comments

@nuttycom
Copy link
Contributor

nuttycom commented Apr 5, 2022

#5819 is missing a regression test. We are merging it without a test to allow for manual testing, but we should have a test to guard against regressions in future refactoring.
@daira daira added this to the Release 5.0.0 milestone Apr 6, 2022
@str4d str4d added A-testing Area: Tests and testing infrastructure I-regression This is a regression, i.e. something that previously worked but now does not due to a change we made labels Apr 6, 2022
@r3ld3v r3ld3v added the S-committed Status: Planned work in a sprint label Apr 14, 2022
@nuttycom
Copy link
Contributor Author

@ebfull and I worked on the tests for this; it does not need to block v5.0.0. Due to issues around timing, it's difficult to make a regression test for this, but we should go ahead and commit the test that we added; it improves coverage even though it didn't fully trigger the original failure case.

@str4d str4d removed this from the Release 5.0.0 milestone May 11, 2022
@nuttycom nuttycom removed the S-committed Status: Planned work in a sprint label Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testing Area: Tests and testing infrastructure I-regression This is a regression, i.e. something that previously worked but now does not due to a change we made
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nuttycom @daira @str4d @r3ld3v