Fix logic for deciding whether to perform Orchard updates during rescan #5819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ebfull looks like you accidentally committed some build artifacts? |
|
Is there a test that can be written to expose the bug that's being fixed? |
In `ScanForWalletTransactions` we skip forward from `pindexStart` to a block near our wallet birthday. But we use this as the basis for deciding the value of `performOrchardWalletUpdates` later, which is wrong because our wallet birthday might be beyond the NU5 activation height. The result is that we won't actually perform the required scanning (mainly witnessing and so forth) needed to spend notes in our wallet.
|
@nuttycom Yeah, an RPC test could probably exercise this. Start a node, do some stufff (like activating NU5), shut it down, delete the wallet, start it up, do some Orchard transactions, shut it down, start it up with rescan, then try to spend your Orchard funds. At least I think that would do it. |
str4d
added
C-bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
ScanForWalletTransactionswe skip forward frompindexStartto a blocknear our wallet birthday. But we use this as the basis for deciding the value
of
performOrchardWalletUpdateslater, which is wrong because our walletbirthday might be beyond the NU5 activation height. The result is that we
won't actually perform the required scanning (mainly witnessing and so forth)
needed to spend notes in our wallet.