Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make updatecheck.py less prone to triggering API rate limits #6061

Open
str4d opened this issue Jul 8, 2022 · 0 comments
Open

Make updatecheck.py less prone to triggering API rate limits #6061

str4d opened this issue Jul 8, 2022 · 0 comments
Labels

Comments

@str4d
Copy link
Contributor

str4d commented Jul 8, 2022

qa/zcash/updatecheck.py checks that our C++ dependencies are either up-to-date or postponed. Most of the dependencies are hosted on GitHub, and the script uses the GitHub API to fetch version information for those dependencies. However, the way it is currently implemented causes many separate requests to be made, which can quickly cause IP address rate limits to be exceeded. This is particularly problematic when trying to test that a new dependency is being checked correctly, or an update has been correctly postponed.

The script should be reworked to reduce the number of GitHub API calls it makes. This might require switching to the GraphQL API, in which case the process for running it would need to be updated / documented, and the release script and process similarly updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant