Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print updatecheck.py output if it fails during make-release.py #6062

Open
str4d opened this issue Jul 8, 2022 · 0 comments
Open

Print updatecheck.py output if it fails during make-release.py #6062

str4d opened this issue Jul 8, 2022 · 0 comments
Labels
A-dependencies Area: Dependencies C-release Category: This is an issue corresponding to the creation of a specific release. dev policy I-error-handling Problems and improvements related to error handling

Comments

@str4d
Copy link
Contributor

str4d commented Jul 8, 2022

The release script zcutil/makerelease.py blocks on C++ dependencies being either up-to-date or postponed. This is checked by qa/zcash/updatecheck.py, but that currently has a problem where running it too many times in a row can hit API rate limits (#6061). Right now, when the release script fails for this reason, the user will likely run the update checker script manually to figure out what the cause was, reducing the number of times they can run it while fixing the problem, and potentially blocking the release process entirely.

We should print out the output of updatecheck.py in this situation to ease the API rate limit pressure a bit.

@str4d str4d added dev policy I-error-handling Problems and improvements related to error handling C-release Category: This is an issue corresponding to the creation of a specific release. A-dependencies Area: Dependencies labels Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependencies C-release Category: This is an issue corresponding to the creation of a specific release. dev policy I-error-handling Problems and improvements related to error handling
Projects
None yet
Development

No branches or pull requests

1 participant