Separate concepts of block difficulty and network difficulty in RPC #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str4d
added
S-waiting-on-review
str4d
added this to the
Beta 1 - complete RPC, audit mitigations, other linux support, user bugfixes milestone
| @@ -140,6 +140,7 @@ extern int64_t nWalletUnlockTime; | |||
| extern CAmount AmountFromValue(const json_spirit::Value& value); | |||
| extern json_spirit::Value ValueFromAmount(const CAmount& amount); | |||
| extern double GetDifficulty(const CBlockIndex* blockindex = NULL); | |||
| extern double GetNetworkDifficulty(const CBlockIndex* blockindex = NULL); | |||
There was a problem hiding this comment.
Arrgh C++ is horrible (default arguments in declaration but not definition).
|
utACK, needs a test. |
"Block difficulty" is the difficulty listed in a block's header, which in the testnet can sometimes be min-difficulty (if time-since-last-block is too large). "Network difficulty" is the difficulty that the network was trying to satisfy at a particular block height. In mainnet this is always equal to the difficulty of the solved block for that height, but in testnet the network difficulty is derived from the last non-min-difficulty block difficulty. This commit fixes the RPC APIs that are intended to show network difficulty, so that on testnet they don't sometimes drop to 1.0, confusing users. Closes zcash#1181
str4d
force-pushed
the
1181-getmininginfo-testnet-difficulty-rules
branch
from
a36b8e9
to
00939d0
Compare
|
Rebased on latest so that I could add the test to the newly-added |
|
ACK, good coverage. Thanks for writing that test. Good work! @zkbot r+ |
|
📌 Commit a36b8e9 has been approved by |
|
💡 This pull request was already approved, no need to approve it again. |
|
🙀 |
|
I updated the |
zkbot
pushed a commit
that referenced
this pull request
Sep 1, 2016
…es, r=ebfull Separate concepts of block difficulty and network difficulty in RPC "Block difficulty" is the difficulty listed in a block's header, which in the testnet can sometimes be min-difficulty (if time-since-last-block is too large). "Network difficulty" is the difficulty that the network was trying to satisfy at a particular block height. In mainnet this is always equal to the difficulty of the solved block for that height, but in testnet the network difficulty is derived from the last non-min-difficulty block difficulty. This commit fixes the RPC APIs that are intended to show network difficulty, so that on testnet they don't sometimes drop to 1.0, confusing users. Closes #1181
|
☀️ Test successful - zcash |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Block difficulty" is the difficulty listed in a block's header, which in the
testnet can sometimes be min-difficulty (if time-since-last-block is too large).
"Network difficulty" is the difficulty that the network was trying to satisfy
at a particular block height. In mainnet this is always equal to the difficulty
of the solved block for that height, but in testnet the network difficulty is
derived from the last non-min-difficulty block difficulty.
This commit fixes the RPC APIs that are intended to show network difficulty, so
that on testnet they don't sometimes drop to 1.0, confusing users.
Closes #1181