Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NCC-2016-015 - Out-of-bounds Read in Boost date Class #1459

Closed
rcseacord opened this issue Sep 30, 2016 · 2 comments
Closed

NCC-2016-015 - Out-of-bounds Read in Boost date Class #1459

rcseacord opened this issue Sep 30, 2016 · 2 comments
Assignees
@daira
Labels
C-audit Category: Issues and tasks related to audit findings I-SECURITY Problems and improvements related to security. M-has-pr To-be-removed (GitHub has linked:pr filter)
Milestone
1.0.0-rc2

Comments

@rcseacord
Copy link
Contributor

rcseacord commented Sep 30, 2016 •
edited by daira
Loading

[Edit by Daira]

A two-byte stack based overflow in a date constructor in the Boost libraries is undefined
behavior and may result in data leaks.
@daira daira added I-SECURITY Problems and improvements related to security. NCC finding labels Sep 30, 2016
@nathan-at-least nathan-at-least added this to the 1.0.0-rc1 milestone Oct 3, 2016
@nathan-at-least nathan-at-least modified the milestones: 1.0.0-rc1, 1.0.0-rc2 Oct 17, 2016
@daira daira mentioned this issue Oct 19, 2016
Merged
daira added a commit to daira/zcash that referenced this issue Oct 20, 2016
@daira
Avoid boost::posix_time functions that have potential out-of-bounds r…
a652e41 
…ead bugs. ref zcash#1459

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
zkbot pushed a commit that referenced this issue Oct 20, 2016
Auto merge of #1571 - daira:1459.avoid-boost-posix-time, r=daira
bb891cb 
Avoid boost::posix_time functions that have potential out-of-bounds read bugs

ref #1459

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
@bitcartel bitcartel added the M-has-pr To-be-removed (GitHub has linked:pr filter) label Oct 20, 2016
daira added a commit to daira/zcash that referenced this issue Oct 21, 2016
@daira
Revert "Avoid boost::posix_time functions that have potential out-of-…
f19cb7b 
…bounds read bugs. ref zcash#1459"

This reverts commit a652e41.
str4d added a commit to str4d/zcash that referenced this issue Oct 22, 2016
@str4d
Revert "Revert "Avoid boost::posix_time functions that have potential…
09864ab 
… out-of-bounds read bugs. ref zcash#1459""

This reverts commit f19cb7b.
@str4d str4d mentioned this issue Oct 22, 2016
Merged
zkbot pushed a commit that referenced this issue Oct 22, 2016
Auto merge of #1601 - str4d:1459-revert-reversion, r=daira
0b38094 
Revert "Revert "Avoid boost::posix_time functions that have potential out-of-bounds read bugs. ref #1459""

This reverts commit f19cb7b.

Closes #1459.
@daira daira changed the title NCC-2016-015 NCC-2016-015 - Out-of-bounds Read in Boost date Class Oct 23, 2016
@daira daira reopened this Oct 23, 2016
@daira daira closed this as completed Oct 23, 2016
@daira
Copy link
Contributor

daira commented Oct 25, 2016 •
edited
Loading

@sehetw on Twitter pointed out that

Last time I checked the epoch for chrono clocks is unspecified (implementation defined). (different for various clocks?)

@daira daira reopened this Oct 25, 2016
@daira daira modified the milestones: 1.0.1 stabilization, 1.0.0-rc2 Oct 25, 2016
@daira daira removed this from the 1.0.1 stabilization milestone Oct 25, 2016
@daira
Copy link
Contributor

daira commented Oct 25, 2016

Actually I'll open another ticket for that.

@daira daira closed this as completed Oct 25, 2016
@daira daira mentioned this issue Oct 25, 2016
Open
@str4d str4d added the C-audit Category: Issues and tasks related to audit findings label Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daira daira

Labels
C-audit Category: Issues and tasks related to audit findings I-SECURITY Problems and improvements related to security. M-has-pr To-be-removed (GitHub has linked:pr filter)
Projects
None yet
Milestone
1.0.0-rc2
Development

No branches or pull requests
5 participants
@bitcartel @daira @rcseacord @nathan-at-least @str4d