Add vjoinsplit to JSON output of RPC call gettransaction #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitcartel
added
the
S-waiting-on-review
|
utACK. |
|
ACK |
|
git's diff is annoying here, perhaps you can trick it by placing the new function after the wrapper function. Anyway, ACK. |
|
@zkbot r+ |
|
📌 Commit f7cfb52 has been approved by |
zkbot
pushed a commit
that referenced
this pull request
Oct 8, 2016
Add vjoinsplit to JSON output of RPC call gettransaction Closes #1446.
bitcartel
removed
the
S-waiting-on-review
|
☀️ Test successful - zcash |
str4d
added a commit
to str4d/zcash
that referenced
this pull request
Feb 16, 2017
This reverts zcash#1493, for two reasons: - The information is unnecessary for a wallet RPC method, which should be showing wallet-contextual information. - As a side-effect, the information also shows up in e.g. listsinceblock, which greatly increases its verbosity for zero benefit. To obtain the JoinSplit data in this format, users should instead pass the "hex" field from gettransaction to decoderawtransaction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1446.