Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust consensus rule to accept genesis block without height in coinbase #1754

Merged

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Nov 2, 2016

Closes #1753

@str4d str4d added C-bug Category: This is a bug A-consensus Area: Consensus rules S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. A-consensus-genesis Area: Starting a Zcash chain from scratch. labels Nov 2, 2016
@str4d str4d added this to the 1.0.1 milestone Nov 2, 2016
@str4d str4d added the I-error-handling Problems and improvements related to error handling label Nov 2, 2016
@ebfull
Copy link
Contributor

ebfull commented Nov 2, 2016

ACK

1 similar comment
@bitcartel
Copy link
Contributor

ACK

@str4d
Copy link
Contributor Author

str4d commented Nov 2, 2016

@zkbot r+

@zkbot
Copy link
Contributor

zkbot commented Nov 2, 2016

📌 Commit 548bbd9 has been approved by str4d

@zkbot
Copy link
Contributor

zkbot commented Nov 2, 2016

⌛ Testing commit 548bbd9 with merge 51a5737...

zkbot pushed a commit that referenced this pull request Nov 2, 2016
…ion, r=str4d

Adjust consensus rule to accept genesis block without height in coinbase

Closes #1753
@zkbot
Copy link
Contributor

zkbot commented Nov 2, 2016

☀️ Test successful - zcash

@zkbot zkbot merged commit 548bbd9 into zcash:master Nov 2, 2016
@str4d str4d deleted the 1753-genesis-block-coinbase-height-exception branch November 3, 2016 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Area: Consensus rules A-consensus-genesis Area: Starting a Zcash chain from scratch. C-bug Category: This is a bug I-error-handling Problems and improvements related to error handling S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants