Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves usability of fetch-params.sh #1759

Merged
merged 1 commit into from Nov 3, 2016
Merged

Conversation

@ageis
Copy link
Contributor

@ageis ageis commented Nov 2, 2016

Remove the lockfile at the end (fixes #1731)
Makes it clearer what happens in the script output if params already exist.

Remove the lockfile at the end (fixes #1731)
Makes it clearer what happens in the script output if params already exist.
@nathan-at-least
Copy link
Contributor

@nathan-at-least nathan-at-least commented Nov 3, 2016

Code review ack.

@str4d
Copy link
Contributor

@str4d str4d commented Nov 3, 2016

utACK

1 similar comment
@ebfull
Copy link
Contributor

@ebfull ebfull commented Nov 3, 2016

utACK

@str4d
Copy link
Contributor

@str4d str4d commented Nov 3, 2016

Merge #1767 #1771 before this.

@ebfull
Copy link
Contributor

@ebfull ebfull commented Nov 3, 2016

@zkbot r+

@zkbot
Copy link
Collaborator

@zkbot zkbot commented Nov 3, 2016

📌 Commit 4bc627b has been approved by ebfull

@zkbot
Copy link
Collaborator

@zkbot zkbot commented Nov 3, 2016

Testing commit 4bc627b with merge 231d2cc...

zkbot pushed a commit that referenced this pull request Nov 3, 2016
Improves usability of fetch-params.sh

Remove the lockfile at the end (fixes #1731)
Makes it clearer what happens in the script output if params already exist.
@zkbot
Copy link
Collaborator

@zkbot zkbot commented Nov 3, 2016

☀️ Test successful - zcash

@zkbot zkbot merged commit 4bc627b into zcash:master Nov 3, 2016
1 check passed
1 check passed
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.