New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves usability of fetch-params.sh #1759

Merged
merged 1 commit into from Nov 3, 2016

Conversation

Projects
None yet
5 participants
@ageis
Contributor

ageis commented Nov 2, 2016

Remove the lockfile at the end (fixes #1731)
Makes it clearer what happens in the script output if params already exist.

Improves usability of fetch-params.sh
Remove the lockfile at the end (fixes #1731)
Makes it clearer what happens in the script output if params already exist.
@nathan-at-least

This comment has been minimized.

Show comment
Hide comment
@nathan-at-least

nathan-at-least Nov 3, 2016

Contributor

Code review ack.

Contributor

nathan-at-least commented Nov 3, 2016

Code review ack.

@str4d

This comment has been minimized.

Show comment
Hide comment
@str4d

str4d Nov 3, 2016

Contributor

utACK

Contributor

str4d commented Nov 3, 2016

utACK

@ebfull

This comment has been minimized.

Show comment
Hide comment
@ebfull

ebfull Nov 3, 2016

Contributor

utACK

Contributor

ebfull commented Nov 3, 2016

utACK

@str4d

This comment has been minimized.

Show comment
Hide comment
@str4d

str4d Nov 3, 2016

Contributor

Merge #1767 #1771 before this.

Contributor

str4d commented Nov 3, 2016

Merge #1767 #1771 before this.

@ebfull

This comment has been minimized.

Show comment
Hide comment
@ebfull

ebfull Nov 3, 2016

Contributor

@zkbot r+

Contributor

ebfull commented Nov 3, 2016

@zkbot r+

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Nov 3, 2016

Contributor

📌 Commit 4bc627b has been approved by ebfull

Contributor

zkbot commented Nov 3, 2016

📌 Commit 4bc627b has been approved by ebfull

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Nov 3, 2016

Contributor

⌛️ Testing commit 4bc627b with merge 231d2cc...

Contributor

zkbot commented Nov 3, 2016

⌛️ Testing commit 4bc627b with merge 231d2cc...

zkbot pushed a commit that referenced this pull request Nov 3, 2016

zkbot
Auto merge of #1759 - ageis:more-fetch-params-stuff, r=ebfull
Improves usability of fetch-params.sh

Remove the lockfile at the end (fixes #1731)
Makes it clearer what happens in the script output if params already exist.
@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Nov 3, 2016

Contributor

☀️ Test successful - zcash

Contributor

zkbot commented Nov 3, 2016

☀️ Test successful - zcash

@zkbot zkbot merged commit 4bc627b into zcash:master Nov 3, 2016

1 check passed

homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment