Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update libsnark. #2080

Merged
merged 1 commit into from
Feb 10, 2017
Merged

Update libsnark. #2080

merged 1 commit into from
Feb 10, 2017

Conversation

ebfull
Copy link
Contributor

@ebfull ebfull commented Feb 9, 2017 •
edited
Loading

This updates libsnark to adopt zcash/libsnark#11. Do not merge this until zcash/libsnark#11 is merged.

Closes #2043

@ebfull ebfull added this to the 1.0.6 milestone Feb 9, 2017
@bitcartel
Copy link
Contributor

@zkbot try

@zkbot
Copy link
Contributor

zkbot commented Feb 10, 2017

⌛ Trying commit 69566ad with merge ce71dd0...

@zkbot
Copy link
Contributor

zkbot commented Feb 10, 2017

☀️ Test successful - zcash

@bitcartel
Copy link
Contributor

ACK

@bitcartel
Copy link
Contributor

@zkbot r+

@zkbot
Copy link
Contributor

zkbot commented Feb 10, 2017

📌 Commit 69566ad has been approved by bitcartel

@zkbot
Copy link
Contributor

zkbot commented Feb 10, 2017

⌛ Testing commit 69566ad with merge 044f6c4...

@ebfull
Copy link
Contributor Author

ebfull commented Feb 10, 2017

Why try just to r+ after?

@bitcartel
Copy link
Contributor

bitcartel commented Feb 10, 2017 •
edited
Loading

@ebfull Local computer was busy and was waiting for libsnark change to be reviewed and acked.

@ebfull
Copy link
Contributor Author

ebfull commented Feb 10, 2017

If there's something you need from local testing/try that you can't get from r+, there might be something wrong with our CI process. r+ will only merge if tests pass.

@ebfull
Copy link
Contributor Author

ebfull commented Feb 10, 2017

Oh, waiting for the libsnark change to be reviewed/merged sounds like a very good reason.

@zkbot
Copy link
Contributor

zkbot commented Feb 10, 2017

💔 Test failed - zcash

@bitcartel
Copy link
Contributor

Will retry in a bit. We had this problem in the last release where the buildbot server would run slow and the z_sendmany would not finish when the test expects it to have.

@bitcartel
Copy link
Contributor

@zkbot retry

zkbot added a commit that referenced this pull request Feb 10, 2017
@zkbot
Auto merge of #2080 - ebfull:libsnark-update, r=bitcartel
44788f9 
Update libsnark.

This updates libsnark to adopt zcash/libsnark#11. Do not merge this until zcash/libsnark#11 is merged.

Closes #2043
@zkbot
Copy link
Contributor

zkbot commented Feb 10, 2017

⌛ Testing commit 69566ad with merge 44788f9...

@zkbot
Copy link
Contributor

zkbot commented Feb 10, 2017

☀️ Test successful - zcash

@zkbot zkbot merged commit 69566ad into zcash:master Feb 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ebfull @bitcartel @zkbot