Edit release-process.md for clarity #2161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
added
A-documentation
str4d
requested changes
Mar 8, 2017
doc/release-process.md
Outdated
| @@ -53,7 +53,9 @@ In `configure.ac` and `clientversion.h`: | |||
| If this release changes the behavior of the protocol or fixes a serious bug, we may | |||
| also wish to change the `PROTOCOL_VERSION` in `version.h`. | |||
|
|
|||
| Build and commit to update versions, and then perform the following command: | |||
| Build, then commit these changes to update versions. | |||
There was a problem hiding this comment.
Needs to be "commit then build" so that the built binary doesn't include -dirty.
doc/release-process.md
Outdated
| @@ -101,8 +103,9 @@ Run `./fetch-params.sh`. | |||
|
|
|||
| ## D. Make tag for the newly merged result | |||
|
|
|||
| In this example, we ensure master is up to date with the | |||
| previous merged PR, then: | |||
| Checkout master and pull the latest version to ensure master is up to date with the release PR which has recently been reviewed and merged. Check the last commit on the local and remote versions of master to make sure they are the same. | |||
There was a problem hiding this comment.
s/which has recently been reviewed and merged/merged in B4/- Break the line?
arcalinea
force-pushed
the
2160_revise_release_process
branch
from
2ba99e3
to
8144a21
Compare
|
@str4d incorporated your comments |
|
@zkbot r+ |
|
📌 Commit 8144a21 has been approved by |
zkbot
added a commit
that referenced
this pull request
Mar 16, 2017
Edit release-process.md for clarity For #2160
|
☀️ Test successful - zcash |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2160