Change regtest port to 18344. Closes #2269. #2270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daira
approved these changes
Apr 17, 2017
|
Tested, works fine. ACK. @zkbot try |
zkbot
added a commit
that referenced
this pull request
Apr 18, 2017
Change regtest port to 18344. Closes #2269.
|
Hmm, why is this still pending after 11 hours? @ageis? |
|
💥 Test timed out |
|
@zkbot retry |
zkbot
added a commit
that referenced
this pull request
Apr 18, 2017
Change regtest port to 18344. Closes #2269.
|
☀️ Test successful - zcash |
|
@zkbot r+ |
|
📌 Commit 05844ba has been approved by |
|
⌛ Testing commit 05844ba with merge 6142843... |
|
💔 Test failed - zcash |
|
Known-nondeterministic test failure unrelated to this PR. @zkbot retry |
zkbot
added a commit
that referenced
this pull request
Apr 19, 2017
Change regtest port to 18344. Closes #2269.
|
☀️ Test successful - zcash |
|
Are we merging this soon? And oh ugh, I think I fixed the nondeterministic test failure in the latest commit to #2200, should merge that to prevent this from happening |
|
@arcalinea yes, it had already merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.