-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wallet backup instructions #2340
Conversation
I request that reviewers for this ticket literally walk through all instructions with a test wallet. Doing so on mainnet will take some time to sync a new test wallet, so plan accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. I have tested the export commands just now (and verified that -exportdir
is needed to export), and I have previously tested the import commands.
EDIT: I have now (that rescans are finished) tested the import commands.
doc/wallet-backup.md
Outdated
|
||
### Using `dumpwallet` | ||
|
||
This command inherited from bitcoin is depreciated. It will export private keys in a similar fashion as `z_exportwallet` but only for transparent addresses. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bitcoin
deprecated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dumpwallet behavior is confusing.
The command exists but I couldn't get it to work - perhaps because of this deprecation.
It might be better to delete the command if it doesn't work.
doc/wallet-backup.md
Outdated
|
||
This will return the private key and will not create a new file. | ||
|
||
For exporting a single private key for a transparent address, you can use the command inherited from bitcoin: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bitcoin
doc/wallet-backup.md
Outdated
|
||
These instructions are specific for the officially supported Zcash Linux client. For backing up with third-party wallets, please consult with user guides or support channels provided for those services. | ||
|
||
There are multiple ways to make sure you have at least one other copy of the private keys needed to spend ZEC and view shielded ZEC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add "your" before "ZEC" and "Shielded"?
|
||
To create a backup of your wallet, use: | ||
|
||
`zcash-cli backupwallet <nameofbackup>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get
error code: -4
error message:
Cannot backup wallet until the -exportdir option has been set
even though I did add exportdir to zcash.conf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally it worked..
I think the thing was zcashd was running when I changed the zcash.conf
I had to do zcash-cli stop
and then zcashd -daemon
and then also I think it needed to catch up to the latest block
cause also after that when I tried the backup command as written it gave me
error code: -28
error message:
Loading block index...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after a minute when I tried again it worked.
The explanation doesn't mention that zcashd needs to be running for the backup command to work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But also now when it seems to have worked - wrote me the path to the backup file.
When I go to the backup directory I don't see any files, also with ls -a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK that was fine. It just interpreted ~ as a directory name , what's a little confusing about the explanation is that I felt unsure if I just start with /
whether it always starts from the home directory or somewhere else
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated with these suggestions.
doc/wallet-backup.md
Outdated
|
||
To import keys into a wallet which were previously exported to a file, use: | ||
|
||
`zcash-cli z_importwallet <nameofbackup>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be worth noting that when importing you need to write the whole path, it doesn't look automatically in exportdir.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Changed the command to reflect this.
`zcash-cli z_importkey <z-priv-key>` | ||
|
||
This will add the key to your wallet and rescan the wallet for associated transactions if it is not already part of the wallet. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps add:
The rescanning process can take a few minutes for a new private key.
To skip it use
zcash-cli z_importkey <z-priv-key> no
instead.
More generally, see the command's..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Added this.
doc/wallet-backup.md
Outdated
|
||
### Using `dumpwallet` | ||
|
||
This command inherited from bitcoin is depreciated. It will export private keys in a similar fashion as `z_exportwallet` but only for transparent addresses. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dumpwallet behavior is confusing.
The command exists but I couldn't get it to work - perhaps because of this deprecation.
It might be better to delete the command if it doesn't work.
ACK |
@zkbot r+ |
📌 Commit 4088ac6 has been approved by |
⌛ Testing commit 4088ac6 with merge 3f72734e4e9d964da92ea0a816d8f6a35395f5f2... |
💔 Test failed - pr-merge |
@zkbot retry |
⌛ Testing commit 4088ac6 with merge 1d20dfe4ee271580e6d249deb8aae791f18e176e... |
💔 Test failed - pr-merge |
@zkbot retry |
wallet backup instructions closes #2178
closes #2178