Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support per platform filename and hash setting for dependencies #2436

Merged
merged 1 commit into from
Jun 17, 2017
Merged

support per platform filename and hash setting for dependencies #2436

merged 1 commit into from
Jun 17, 2017

Conversation

kozyilmaz
Copy link
Contributor

added to support per-platform Rust packages, tested on macOS Sierra 10.12.5 and Ubuntu 16.04 LTS (issue #2431)

daira
daira approved these changes Jun 9, 2017
View reviewed changes
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. (Have not checked the hash for Rust on OS X.)

@daira daira requested review from ebfull and str4d June 9, 2017 21:45
@daira daira added A-build Area: Build system O-macos Operating system: macOS portability labels Jun 9, 2017
@daira daira added this to the 1.0.10 Release milestone Jun 9, 2017
@str4d str4d added this to Awaiting Review in Portability Jun 14, 2017
str4d
str4d approved these changes Jun 14, 2017
View reviewed changes
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, checked that the darwin package hash matches.

@str4d
Copy link
Contributor

str4d commented Jun 17, 2017

@zkbot r+

@zkbot
Copy link
Contributor

zkbot commented Jun 17, 2017

📌 Commit e6dc07b has been approved by str4d

@zkbot
Copy link
Contributor

zkbot commented Jun 17, 2017

⌛ Testing commit e6dc07b with merge d5934e9...

zkbot added a commit that referenced this pull request Jun 17, 2017
@zkbot
Auto merge of #2436 - kozyilmaz:multipath, r=str4d
d5934e9 
support per platform filename and hash setting for dependencies

added to support per-platform Rust packages, tested on macOS Sierra 10.12.5 and Ubuntu 16.04 LTS (issue #2431)
@zkbot
Copy link
Contributor

zkbot commented Jun 17, 2017

☀️ Test successful - pr-merge
Approved by: str4d
Pushing d5934e9 to master...

@zkbot zkbot merged commit e6dc07b into zcash:master Jun 17, 2017
@kozyilmaz kozyilmaz deleted the multipath branch June 20, 2017 07:14
@nathan-at-least nathan-at-least moved this from Awaiting Review to Blocked in Portability Jun 23, 2017
@nathan-at-least nathan-at-least mentioned this pull request Jun 23, 2017
Closed
@nathan-at-least nathan-at-least moved this from Blocked to Complete in Portability Jun 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daira daira daira approved these changes

@str4d str4d str4d approved these changes

@ebfull ebfull Awaiting requested review from ebfull

Assignees
No one assigned
Labels
A-build Area: Build system O-macos Operating system: macOS portability
Projects
No open projects
Portability
  
Complete
Milestone
1.0.10 Release
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kozyilmaz @str4d @zkbot @daira