Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable building Proton in Gitian #2462

Merged
merged 1 commit into from Jun 24, 2017

Conversation

Projects
None yet
5 participants
@str4d
Copy link
Contributor

commented Jun 22, 2017

This is the patch used to build 1.0.9 and 1.0.10.

Part of #2404.

Disable building Proton in Gitian
This is the patch used to build 1.0.9 and 1.0.10.

Part of #2404.

@str4d str4d added the build label Jun 22, 2017

@str4d str4d added this to the 1.0.11 Release milestone Jun 22, 2017

@daira

daira approved these changes Jun 22, 2017

Copy link
Contributor

left a comment

utACK

@daira

This comment has been minimized.

Copy link
Contributor

commented Jun 22, 2017

Shouldn't we just install cmake and include Proton/AMQP support in (future) gitian builds, though?

@str4d

This comment has been minimized.

Copy link
Contributor Author

commented Jun 22, 2017

@daira yes (that is closing #2404), but that requires more investigation to ensure it is correctly-handled, whereas merging this patch ensures we don't run into this problem again next release.

@daira daira requested a review from bitcartel Jun 23, 2017

@ebfull

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2017

@zkbot r+

@zkbot

This comment has been minimized.

Copy link
Collaborator

commented Jun 24, 2017

📌 Commit f86111d has been approved by ebfull

@zkbot

This comment has been minimized.

Copy link
Collaborator

commented Jun 24, 2017

⌛️ Testing commit f86111d with merge ad5e8a5...

zkbot added a commit that referenced this pull request Jun 24, 2017

Auto merge of #2462 - str4d:2404-gitian-no-proton, r=ebfull
Disable building Proton in Gitian

This is the patch used to build 1.0.9 and 1.0.10.

Part of #2404.
@zkbot

This comment has been minimized.

Copy link
Collaborator

commented Jun 24, 2017

☀️ Test successful - pr-merge
Approved by: ebfull
Pushing ad5e8a5 to master...

@zkbot zkbot merged commit f86111d into zcash:master Jun 24, 2017

1 check passed

homu Test successful
Details

@daira daira modified the milestones: 1.0.10-1, 1.0.11 Release Jun 24, 2017

@daira daira added this to Blocked in Security and Stability Jul 3, 2017

@daira daira moved this from Blocked to Complete in Security and Stability Jul 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.