Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable building Proton in Gitian #2462

Merged
merged 1 commit into from Jun 24, 2017
Merged

Disable building Proton in Gitian #2462

merged 1 commit into from Jun 24, 2017

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Jun 22, 2017

This is the patch used to build 1.0.9 and 1.0.10.

Part of #2404.

@str4d
Disable building Proton in Gitian
f86111d 
This is the patch used to build 1.0.9 and 1.0.10.

Part of zcash#2404.
@str4d str4d added the A-build Area: Build system label Jun 22, 2017
@str4d str4d added this to the 1.0.11 Release milestone Jun 22, 2017
daira
daira approved these changes Jun 22, 2017
View reviewed changes
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@daira
Copy link
Contributor

daira commented Jun 22, 2017 •
edited

Shouldn't we just install cmake and include Proton/AMQP support in (future) gitian builds, though?

@str4d
Copy link
Contributor Author

str4d commented Jun 22, 2017

@daira yes (that is closing #2404), but that requires more investigation to ensure it is correctly-handled, whereas merging this patch ensures we don't run into this problem again next release.

@daira daira requested a review from bitcartel June 23, 2017 07:01
@ebfull
Copy link
Contributor

ebfull commented Jun 24, 2017

@zkbot r+

@zkbot
Copy link
Contributor

zkbot commented Jun 24, 2017

📌 Commit f86111d has been approved by ebfull

@zkbot
Copy link
Contributor

zkbot commented Jun 24, 2017

⌛ Testing commit f86111d with merge ad5e8a5...

zkbot added a commit that referenced this pull request Jun 24, 2017
@zkbot
Auto merge of #2462 - str4d:2404-gitian-no-proton, r=ebfull
ad5e8a5 
Disable building Proton in Gitian

This is the patch used to build 1.0.9 and 1.0.10.

Part of #2404.
@zkbot
Copy link
Contributor

zkbot commented Jun 24, 2017

☀️ Test successful - pr-merge
Approved by: ebfull
Pushing ad5e8a5 to master...

@zkbot zkbot merged commit f86111d into zcash:master Jun 24, 2017
@daira daira modified the milestones: 1.0.10-1, 1.0.11 Release Jun 24, 2017
@daira daira added this to Blocked in Security and Stability Jul 3, 2017
@daira daira moved this from Blocked to Complete in Security and Stability Jul 3, 2017
@str4d str4d deleted the 2404-gitian-no-proton branch January 27, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitcartel bitcartel bitcartel approved these changes

@daira daira daira approved these changes

Assignees
No one assigned
Labels
A-build Area: Build system
Projects
None yet
Milestone
1.0.10-1 Release
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@str4d @daira @ebfull @zkbot @bitcartel