Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Add block download progress to metrics UI #2484
nathan-at-least left a comment
There are some pathological cases and I'm not sure if they are reachable.
If not, an improvement would be to add precondition assertions to guard against undefined behavior (if that is indeed C++ divide by zero behavior). Otherwise test cases for them and error recovery would be good. I don't see either of those as requirements for merging this.