Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a listunspent benchmark #2645

Closed
str4d opened this issue Sep 28, 2017 · 1 comment
Closed

Add a listunspent benchmark #2645

str4d opened this issue Sep 28, 2017 · 1 comment
Labels
A-benchmarks Area: Benchmarks I-performance Problems and improvements with respect to performance M-has-pr To-be-removed (GitHub has linked:pr filter) special to Zooko
Projects
User Support
Milestone
1.0.13 CI release

Comments

@str4d
Copy link
Contributor

str4d commented Sep 28, 2017

Per a user report: they have moved from using sendtoaddress to manually creating transactions for efficiency, and listunspent is now their bottleneck. We should benchmark that independently of sendtoaddress - the former will be a component of the latter's performance, so by tracking both we should be able to get better insight into performance improvements.
@str4d str4d added A-benchmarks Area: Benchmarks I-performance Problems and improvements with respect to performance labels Sep 28, 2017
@str4d str4d added this to the 1.0.13 CI release milestone Sep 28, 2017
@daira daira added this to 1.0.13: Performance Improvements in Release planning Sep 28, 2017
@arcalinea arcalinea added this to Work Queue in User Support Oct 2, 2017
str4d added a commit to str4d/zcash that referenced this issue Oct 4, 2017
@str4d
Add benchmark for listunspent
99dd50c 
Closes zcash#2645.
@str4d str4d mentioned this issue Oct 4, 2017
Merged
@str4d str4d added the M-has-pr To-be-removed (GitHub has linked:pr filter) label Oct 4, 2017
zkbot added a commit that referenced this issue Oct 12, 2017
@zkbot
Auto merge of #2650 - str4d:2645-listunspent-benchmark, r=str4d
af549fe 
Add benchmark for listunspent

Closes #2645.
@ioptio
Copy link
Contributor

ioptio commented Oct 16, 2017

@str4d is there a user the user support team can do follow-up with for this issue once 1.0.13 is out?

@ioptio ioptio moved this from Work Queue to User Follow-up in User Support Oct 16, 2017
@ioptio ioptio moved this from User Follow-up to Complete in User Support Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-benchmarks Area: Benchmarks I-performance Problems and improvements with respect to performance M-has-pr To-be-removed (GitHub has linked:pr filter) special to Zooko
Projects
User Support
  
Complete
Milestone
1.0.13 CI release
Development

No branches or pull requests
3 participants
@ioptio @str4d @zookozcash