Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add memory benchmark for validatelargetx #2659

Merged
merged 1 commit into from
Oct 12, 2017
Merged

Add memory benchmark for validatelargetx #2659

merged 1 commit into from
Oct 12, 2017

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Oct 9, 2017

Closes #2377.

@str4d str4d added A-CI Area: Continuous Integration I-performance Problems and improvements with respect to performance A-testing Area: Tests and testing infrastructure labels Oct 9, 2017
@str4d str4d added this to the 1.0.13 CI release milestone Oct 9, 2017
@str4d str4d mentioned this pull request Oct 9, 2017
Closed
@str4d str4d requested a review from daira October 10, 2017 23:15
daira
daira approved these changes Oct 10, 2017
View reviewed changes
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@str4d
Copy link
Contributor Author

str4d commented Oct 12, 2017

Gonna give this a trivial self-ACK.

@str4d
Copy link
Contributor Author

str4d commented Oct 12, 2017

@zkbot r+

@zkbot
Copy link
Contributor

zkbot commented Oct 12, 2017

📌 Commit 94790c5 has been approved by str4d

@zkbot
Copy link
Contributor

zkbot commented Oct 12, 2017

⌛ Testing commit 94790c5 with merge 9f9d552010498663b78e0d163b4ab4cd1d289d7d...

@zkbot
Copy link
Contributor

zkbot commented Oct 12, 2017

💔 Test failed - pr-merge

@str4d
Copy link
Contributor Author

str4d commented Oct 12, 2017

Transient failure.

@zkbot retry

@zkbot
Copy link
Contributor

zkbot commented Oct 12, 2017

⌛ Testing commit 94790c5 with merge 4ad2f17...

zkbot added a commit that referenced this pull request Oct 12, 2017
@zkbot
Auto merge of #2659 - str4d:2377-memory-validatelargetx, r=str4d
4ad2f17 
Add memory benchmark for validatelargetx

Closes #2377.
@zkbot
Copy link
Contributor

zkbot commented Oct 12, 2017

☀️ Test successful - pr-merge
Approved by: str4d
Pushing 4ad2f17 to master...

@zkbot zkbot merged commit 94790c5 into zcash:master Oct 12, 2017
@str4d str4d deleted the 2377-memory-validatelargetx branch October 12, 2017 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daira daira daira approved these changes

Assignees
No one assigned
Labels
A-CI Area: Continuous Integration A-testing Area: Tests and testing infrastructure I-performance Problems and improvements with respect to performance
Projects
None yet
Milestone
1.0.13 CI release
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@str4d @zkbot @daira