Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken pipe error on some platforms when running qa test wallet_protectcoinbase.py #2698

Merged
merged 1 commit into from
Oct 31, 2017
Merged

Fix broken pipe error on some platforms when running qa test wallet_protectcoinbase.py #2698

merged 1 commit into from
Oct 31, 2017

Conversation

bitcartel
Copy link
Contributor

Closes #2263.

@bitcartel bitcartel added this to the 1.0.13 milestone Oct 30, 2017
@bitcartel
Copy link
Contributor Author

@zkbot try

@zkbot
Copy link
Contributor

zkbot commented Oct 30, 2017

⌛ Trying commit cf72e8e with merge 461e4de8ce6ce26611f29c1d29cfda00ae2c0e43...

@bitcartel
Copy link
Contributor Author

@str4d Is this hanging? How can I see what's happening in CI?

@str4d
Copy link
Contributor

str4d commented Oct 30, 2017

If you went to https://ci.z.cash/#/builders/6/builds/25 you'd have seen that it was hanging on "waiting for workers to be available". I stopped pr-try manually, which revealed that there was an issue with AWS credentials (IDK why). The reason this PR hasn't been updated is because stopping pr-try or pr-merge manually doesn't return the right thing for Homu to detect (it needs them to finish with "error" rather than "cancelled").

@str4d
Copy link
Contributor

str4d commented Oct 30, 2017

@zkbot clear

@str4d
Copy link
Contributor

str4d commented Oct 30, 2017

@zkbot try

@str4d
Copy link
Contributor

str4d commented Oct 30, 2017

@zkbot retry

@zkbot
Copy link
Contributor

zkbot commented Oct 30, 2017

⌛ Trying commit cf72e8e with merge b031ff5a6fb684f0ee90a1d49895facbc2abc619...

@bitcartel
Copy link
Contributor Author

bitcartel commented Oct 30, 2017 •
edited
Loading

Yep, I saw 25 but hadn't come across "workers to be available" before. I tried [at] zkbot force but that doesn't seem to do anything.

@zkbot
Copy link
Contributor

zkbot commented Oct 30, 2017

💔 Test failed - pr-try

@str4d
Copy link
Contributor

str4d commented Oct 30, 2017

@bitcartel For future reference, using zkbot's handle in any message will be detected by Homu - you just caused Homu to fail the try by using force 😛

@bitcartel
Copy link
Contributor Author

@str4d Yes, I typed @ by accident, and then edited to [at] but too late.

@bitcartel
Copy link
Contributor Author

@zkbot retry

@zkbot
Copy link
Contributor

zkbot commented Oct 31, 2017

⌛ Trying commit cf72e8e with merge efb71b881d98032e49716f979adcf12d20b32829...

@zkbot
Copy link
Contributor

zkbot commented Oct 31, 2017

💔 Test failed - pr-try

@str4d
Copy link
Contributor

str4d commented Oct 31, 2017

Problem was a clock sync issue between the CI server and AWS.

@zkbot retry

@zkbot
Copy link
Contributor

zkbot commented Oct 31, 2017

⌛ Trying commit cf72e8e with merge d5a4a17662803300ec8303a2ead194231ed0d9f8...

@zkbot
Copy link
Contributor

zkbot commented Oct 31, 2017

☀️ Test successful - pr-try
State: approved= try=True

@bitcartel bitcartel requested review from daira and str4d October 31, 2017 14:18
@bitcartel bitcartel added the A-testing Area: Tests and testing infrastructure label Oct 31, 2017
@bitcartel bitcartel self-assigned this Oct 31, 2017
@bitcartel
Copy link
Contributor Author

@str4d Results look good. Pass for debian 8, debian 8 ktichen sink and ubuntu. The other unsupported CI builders failed for other unrelated reasons.

daira
daira approved these changes Oct 31, 2017
View reviewed changes
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. @str4d will open a ticket about the underlying RPC server problem.

str4d
str4d approved these changes Oct 31, 2017
View reviewed changes
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. Seems like a good temporary fix. I've opened #2701 to track the underlying problem.

@str4d
Copy link
Contributor

str4d commented Oct 31, 2017

@zkbot r+

@zkbot
Copy link
Contributor

zkbot commented Oct 31, 2017

📌 Commit cf72e8e has been approved by str4d

@zkbot
Copy link
Contributor

zkbot commented Oct 31, 2017

⌛ Testing commit cf72e8e with merge 08c91f4...

zkbot added a commit that referenced this pull request Oct 31, 2017
@zkbot
Auto merge of #2698 - bitcartel:2263_fix_broken_pipe, r=str4d
08c91f4 
Fix broken pipe error on some platforms when running qa test wallet_protectcoinbase.py

Closes #2263.
@zkbot
Copy link
Contributor

zkbot commented Oct 31, 2017

☀️ Test successful - pr-merge
Approved by: str4d
Pushing 08c91f4 to master...

@zkbot zkbot merged commit cf72e8e into zcash:master Oct 31, 2017
@zkbot zkbot mentioned this pull request Oct 31, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daira daira daira approved these changes

@str4d str4d str4d approved these changes

Assignees

@bitcartel bitcartel

Labels
A-testing Area: Tests and testing infrastructure
Projects
None yet
Milestone
v1.0.13
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bitcartel @zkbot @str4d @daira