-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add examples for z_rpc calls #2724
Conversation
Can you squash the commits? |
7741747
to
337a99a
Compare
Squashed |
@bitcartel latest commit addresses #2777 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
@zkbot r+ |
📌 Commit 9eb8089 has been approved by |
⌛ Testing commit 9eb8089 with merge 28c2ea56c86f8a27e66eb6aaa4b59259e672291f... |
💔 Test failed - pr-merge |
Temporary failure downloading libsodium from the upstream server. I've cached it on our servers. @zkbot retry |
Add examples for z_rpc calls Adds missing cli and json-rpc examples for `z_` rpc calls Closes #2723 (Accidentally named the branch being merged in with wrong issue number)
" \"remainingUTXOs\": xxx (numeric) Number of coinbase utxos still available for shielding.\n" | ||
" \"remainingValue\": xxx (numeric) Value of coinbase utxos still available for shielding.\n" | ||
" \"shieldingUTXOs\": xxx (numeric) Number of coinbase utxos being shielded.\n" | ||
" \"shieldingValue\": xxx (numeric) Value of coinbase utxos being shielded.\n" | ||
" \"opid\": xxx (string) An operationid to pass to z_getoperationstatus to get the result of the operation.\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I hadn't realized that we were inconsistent in the naming of this field between different operations. That's unfortunate.
Adds missing cli and json-rpc examples for
z_
rpc callsCloses #2723