Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples for z_rpc calls #2724

Merged
merged 2 commits into from
Dec 4, 2017

Conversation

arcalinea
Copy link
Contributor

@arcalinea arcalinea commented Nov 14, 2017

Adds missing cli and json-rpc examples for z_ rpc calls

Closes #2723

@bitcartel
Copy link
Contributor

Can you squash the commits?

@bitcartel bitcartel added this to the 1.0.14 milestone Nov 17, 2017
@bitcartel bitcartel added A-documentation Area: Documentation A-rpc-interface Area: RPC interface labels Nov 17, 2017
@arcalinea
Copy link
Contributor Author

Squashed

@arcalinea
Copy link
Contributor Author

@bitcartel latest commit addresses #2777

Copy link
Contributor

@arielgabizon arielgabizon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job.

Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@str4d
Copy link
Contributor

str4d commented Dec 4, 2017

@zkbot r+

@zkbot
Copy link
Contributor

zkbot commented Dec 4, 2017

📌 Commit 9eb8089 has been approved by str4d

@zkbot
Copy link
Contributor

zkbot commented Dec 4, 2017

⌛ Testing commit 9eb8089 with merge 28c2ea56c86f8a27e66eb6aaa4b59259e672291f...

@zkbot
Copy link
Contributor

zkbot commented Dec 4, 2017

💔 Test failed - pr-merge

@str4d
Copy link
Contributor

str4d commented Dec 4, 2017

Temporary failure downloading libsodium from the upstream server. I've cached it on our servers.

@zkbot retry

@zkbot
Copy link
Contributor

zkbot commented Dec 4, 2017

⌛ Testing commit 9eb8089 with merge 28e0159...

zkbot added a commit that referenced this pull request Dec 4, 2017
Add examples for z_rpc calls

Adds missing cli and json-rpc examples for `z_` rpc calls

Closes #2723
(Accidentally named the branch being merged in with wrong issue number)
@zkbot
Copy link
Contributor

zkbot commented Dec 4, 2017

☀️ Test successful - pr-merge
Approved by: str4d
Pushing 28e0159 to master...

" \"remainingUTXOs\": xxx (numeric) Number of coinbase utxos still available for shielding.\n"
" \"remainingValue\": xxx (numeric) Value of coinbase utxos still available for shielding.\n"
" \"shieldingUTXOs\": xxx (numeric) Number of coinbase utxos being shielded.\n"
" \"shieldingValue\": xxx (numeric) Value of coinbase utxos being shielded.\n"
" \"opid\": xxx (string) An operationid to pass to z_getoperationstatus to get the result of the operation.\n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I hadn't realized that we were inconsistent in the naming of this field between different operations. That's unfortunate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-documentation Area: Documentation A-rpc-interface Area: RPC interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants