New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.0.13-rc1 #2733

Merged
merged 4 commits into from Nov 15, 2017

Conversation

Projects
None yet
4 participants
@str4d
Contributor

str4d commented Nov 15, 2017

No description provided.

str4d added some commits Nov 14, 2017

@str4d str4d added the release label Nov 15, 2017

@nathan-at-least

utACK. Some follow up work requested, but no blockers for this PR.

Show outdated Hide outdated src/deprecation.h Outdated
.PP
In order to ensure you are adequately protecting your privacy when using Zcash,
please see <https://z.cash/support/security/index.html>.
please see <https://z.cash/support/security/>.

This comment has been minimized.

@nathan-at-least

nathan-at-least Nov 15, 2017

Contributor

Is this a manual change outside of make-release.py? I prefer to separate make-release.py changes from manual changes in the future, but for now this is acceptable. (If it's somehow the result of make-release.py that would also be notable and maybe a bug.)

@nathan-at-least

nathan-at-least Nov 15, 2017

Contributor

Is this a manual change outside of make-release.py? I prefer to separate make-release.py changes from manual changes in the future, but for now this is acceptable. (If it's somehow the result of make-release.py that would also be notable and maybe a bug.)

This comment has been minimized.

@str4d

str4d Nov 15, 2017

Contributor

This is part of the make-release.py change - it updates man pages, which pull from changes to the help text in init.cpp.

@str4d

str4d Nov 15, 2017

Contributor

This is part of the make-release.py change - it updates man pages, which pull from changes to the help text in init.cpp.

@@ -68,7 +68,7 @@ Timeout in seconds during HTTP requests, or 0 for no timeout. (default:
.SH COPYRIGHT
In order to ensure you are adequately protecting your privacy when using Zcash,
please see <https://z.cash/support/security/index.html>.
please see <https://z.cash/support/security/>.

This comment has been minimized.

@nathan-at-least

nathan-at-least Nov 15, 2017

Contributor

See above.

@nathan-at-least

nathan-at-least Nov 15, 2017

Contributor

See above.

@@ -86,7 +86,7 @@ Set register NAME to given JSON\-STRING
.SH COPYRIGHT
In order to ensure you are adequately protecting your privacy when using Zcash,
please see <https://z.cash/support/security/index.html>.
please see <https://z.cash/support/security/>.

This comment has been minimized.

@nathan-at-least

nathan-at-least Nov 15, 2017

Contributor

See above.

@nathan-at-least

nathan-at-least Nov 15, 2017

Contributor

See above.

@@ -462,7 +462,7 @@ console, 600 otherwise)
.SH COPYRIGHT
In order to ensure you are adequately protecting your privacy when using Zcash,
please see <https://z.cash/support/security/index.html>.
please see <https://z.cash/support/security/>.

This comment has been minimized.

@nathan-at-least

nathan-at-least Nov 15, 2017

Contributor

See above (all changes to this URL).

@nathan-at-least

nathan-at-least Nov 15, 2017

Contributor

See above (all changes to this URL).

@nathan-at-least

utACK on the #2686 change.

Show outdated Hide outdated src/deprecation.h Outdated
@str4d

This comment has been minimized.

Show comment
Hide comment
@str4d

str4d Nov 15, 2017

Contributor

@zkbot r+

Contributor

str4d commented Nov 15, 2017

@zkbot r+

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Nov 15, 2017

Contributor

📌 Commit 66a9fd8 has been approved by str4d

Contributor

zkbot commented Nov 15, 2017

📌 Commit 66a9fd8 has been approved by str4d

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Nov 15, 2017

Contributor

⌛️ Testing commit 66a9fd8 with merge c1282be...

Contributor

zkbot commented Nov 15, 2017

⌛️ Testing commit 66a9fd8 with merge c1282be...

zkbot added a commit that referenced this pull request Nov 15, 2017

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot Nov 15, 2017

Contributor

☀️ Test successful - pr-merge
Approved by: str4d
Pushing c1282be to master...

Contributor

zkbot commented Nov 15, 2017

☀️ Test successful - pr-merge
Approved by: str4d
Pushing c1282be to master...

@zkbot zkbot merged commit 66a9fd8 into zcash:master Nov 15, 2017

1 check passed

homu Test successful
Details
@daira

This comment has been minimized.

Show comment
Hide comment
@daira

daira Nov 15, 2017

Contributor

Post-hoc ACK

Contributor

daira commented Nov 15, 2017

Post-hoc ACK

@daira daira added this to the 1.0.13 milestone Nov 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment