Release v1.0.13-rc1 #2733
Release v1.0.13-rc1 #2733
Conversation
str4d
added
the
C-release
src/deprecation.h
Outdated
| @@ -8,7 +8,7 @@ | |||
| // Deprecation policy: | |||
| // * Shut down 18 weeks' worth of blocks after the estimated release block height. | |||
There was a problem hiding this comment.
[DOES NOT BLOCK] Looks like we missed #2686 for this release.
There was a problem hiding this comment.
Oh, I was going to do that in the actual 1.0.13 release PR, but I can trivially do it in this PR instead (just requires one more commit).
| .PP | ||
| In order to ensure you are adequately protecting your privacy when using Zcash, | ||
| please see <https://z.cash/support/security/index.html>. | ||
| please see <https://z.cash/support/security/>. |
There was a problem hiding this comment.
Is this a manual change outside of make-release.py? I prefer to separate make-release.py changes from manual changes in the future, but for now this is acceptable. (If it's somehow the result of make-release.py that would also be notable and maybe a bug.)
There was a problem hiding this comment.
This is part of the make-release.py change - it updates man pages, which pull from changes to the help text in init.cpp.
| @@ -68,7 +68,7 @@ Timeout in seconds during HTTP requests, or 0 for no timeout. (default: | |||
| .SH COPYRIGHT | |||
|
|
|||
| In order to ensure you are adequately protecting your privacy when using Zcash, | |||
| please see <https://z.cash/support/security/index.html>. | |||
| please see <https://z.cash/support/security/>. | |||
| @@ -86,7 +86,7 @@ Set register NAME to given JSON\-STRING | |||
| .SH COPYRIGHT | |||
|
|
|||
| In order to ensure you are adequately protecting your privacy when using Zcash, | |||
| please see <https://z.cash/support/security/index.html>. | |||
| please see <https://z.cash/support/security/>. | |||
| @@ -462,7 +462,7 @@ console, 600 otherwise) | |||
| .SH COPYRIGHT | |||
|
|
|||
| In order to ensure you are adequately protecting your privacy when using Zcash, | |||
| please see <https://z.cash/support/security/index.html>. | |||
| please see <https://z.cash/support/security/>. | |||
There was a problem hiding this comment.
See above (all changes to this URL).
src/deprecation.h
Outdated
| // * A warning is shown during the 2 weeks' worth of blocks prior to shut down. | ||
| static const int APPROX_RELEASE_HEIGHT = 219700; | ||
| static const int WEEKS_UNTIL_DEPRECATION = 18; | ||
| static const int WEEKS_UNTIL_DEPRECATION = 16; |
|
@zkbot r+ |
|
📌 Commit 66a9fd8 has been approved by |
|
Post-hoc ACK |
No description provided.