Closes #2793 to improve sync performance by increasing default value of dbcache. #2873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitcartel
added
the
I-performance
bitcartel
force-pushed
the
2793_dbcache
branch
from
3371f6a
to
7113674
Compare
str4d
requested changes
Jan 16, 2018
| Notable changes | ||
| =============== | ||
|
|
||
| UTXO memory accounting |
There was a problem hiding this comment.
Put these in doc/release-notes.md, which gets inserted into the correct release notes file at release time. This also means you can just cherry-pick upstream commits directly, and their release notes will go into the correct place.
bitcartel
force-pushed
the
2793_dbcache
branch
from
7113674
to
1f2f9e8
Compare
str4d
approved these changes
Jan 17, 2018
doc/release-notes.md
Outdated
| UTXO memory accounting | ||
| ---------------------- | ||
|
|
||
| The default -dbcache has also been changed in this release to 450MiB. Users can set -dbcache to a higher value (e.g. to keep the UTXO more fully cached in memory). Users on low-memory systems (such as systems with 1GB or less) should consider specifying a lower value for this parameter. |
There was a problem hiding this comment.
Non-blocking: has been changed (non-blocking because I expect other changes will be added that can go before this, to make it grammatically correct).
doc/reducing-memory-usage.md
Outdated
|
|
||
| The size of some in-memory caches can be reduced. As caches trade off memory usage for performance, usually reducing these have a negative effect on performance. | ||
|
|
||
| - `-dbcache=<n>` - the UTXO database cache size, this defaults to `450` (`100` before 1.0.15). The unit is MiB (1024) |
There was a problem hiding this comment.
The (1024) seems like a typo. Maybe expand to (where 1 GiB = 1024 MiB) or something similar?
arcalinea
reviewed
Jan 17, 2018
doc/reducing-memory-usage.md
Outdated
| The size of some in-memory caches can be reduced. As caches trade off memory usage for performance, usually reducing these have a negative effect on performance. | ||
|
|
||
| - `-dbcache=<n>` - the UTXO database cache size, this defaults to `450` (`100` before 1.0.15). The unit is MiB (1024) | ||
| - The minimum value for `-dbcache` is 4. |
There was a problem hiding this comment.
Depends on the platform, so won't document here. Note that zcashd --help already displays the max amount: Set database cache size in megabytes (4 to 16384, default: 450)
|
ACK. @zkbot try |
zkbot
added a commit
that referenced
this pull request
Jan 17, 2018
Closes #2793 to improve sync performance by increasing default value of dbcache.
|
☀️ Test successful - pr-try |
Adapted from documentation 'Reducing bitcoind memory usage' by @laanwj https://gist.github.com/laanwj/efe29c7661ce9b6620a7
bitcartel
force-pushed
the
2793_dbcache
branch
from
1f2f9e8
to
92adc51
Compare
|
@str4d updated documentation |
str4d
approved these changes
Jan 19, 2018
doc/release-notes.md
Outdated
| UTXO memory accounting | ||
| ---------------------- | ||
|
|
||
| The default -dbcache has been changed in this release to 450MiB. Users can set -dbcache to a higher value (e.g. to keep the UTXO more fully cached in memory). Users on low-memory systems (such as systems with 1GB or less) should consider specifying a lower value for this parameter. |
There was a problem hiding this comment.
Non-blocking: "to keep the UTXO set"
Adapted from upstream release notes here: https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-0.14.1.md#utxo-memory-accounting
bitcartel
force-pushed
the
2793_dbcache
branch
from
92adc51
to
d2b77b7
Compare
|
@zkbot r+ |
|
📌 Commit d2b77b7 has been approved by |
zkbot
added a commit
that referenced
this pull request
Jan 20, 2018
Closes #2793 to improve sync performance by increasing default value of dbcache.
This was referenced Jan 20, 2018
Merged
Merged
tearodactyl
pushed a commit
to tearodactyl/z18
that referenced
this pull request
May 9, 2018
Update version string Pull in select 1.0.15 Zcash fixes: read hashReserved from disk zcash#2931 improve sync performance by increasing default value of dbcache. zcash#2873 z_importviewingkey fix from leto/zero/pull/1 Update README.md throughout, particularly the addnode addresses, plus add a sample zero.conf to ./contrib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.