Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Equihash solution when loading block index #2977

Merged
merged 1 commit into from Feb 22, 2018

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Feb 21, 2018

An additional consistency check, which also ensures that the in-memory representation
matches the stored index.

@str4d str4d added the I-error-handling Problems and improvements related to error handling label Feb 21, 2018
@str4d str4d added this to the v1.0.15 milestone Feb 21, 2018
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ebfull ebfull self-requested a review February 22, 2018 02:21
@str4d
Copy link
Contributor Author

str4d commented Feb 22, 2018

@zkbot r+

@zkbot
Copy link
Contributor

zkbot commented Feb 22, 2018

📌 Commit 4448840 has been approved by str4d

@str4d str4d removed the request for review from bitcartel February 22, 2018 02:38
@zkbot
Copy link
Contributor

zkbot commented Feb 22, 2018

⌛ Testing commit 4448840 with merge 5040031...

zkbot added a commit that referenced this pull request Feb 22, 2018
Check Equihash solution when loading block index

An additional consistency check, which also ensures that the in-memory representation
matches the stored index.
@zkbot
Copy link
Contributor

zkbot commented Feb 22, 2018

☀️ Test successful - pr-merge
Approved by: str4d
Pushing 5040031 to master...

@zkbot zkbot merged commit 4448840 into zcash:master Feb 22, 2018
@str4d str4d deleted the loadblockindexguts-correctness branch February 22, 2018 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I-error-handling Problems and improvements related to error handling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants