Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #3084. Log txid when removing expired transactions from mempool. #3090

Merged
merged 2 commits into from
Mar 19, 2018
Merged

Closes #3084. Log txid when removing expired transactions from mempool. #3090

merged 2 commits into from
Mar 19, 2018

Conversation

bitcartel
Copy link
Contributor

No description provided.

@bitcartel bitcartel added this to the v1.1.0 milestone Mar 16, 2018
@bitcartel bitcartel self-assigned this Mar 16, 2018
@bitcartel bitcartel added this to Work Queue in Network Upgrade 0 via automation Mar 16, 2018
@bitcartel
Copy link
Contributor Author

For reviewers, run the qa test and inspect debug.log of node0 and node1.

qa/pull-tester/rpc-tests.sh mempool_tx_expiry --nocleanup

str4d
str4d approved these changes Mar 19, 2018
View reviewed changes
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, I see the log output.

@mdr0id
Copy link
Contributor

mdr0id commented Mar 19, 2018

Tested ACK:

=== Running testscript mempool_tx_expiry.py ===
Initializing test directory /tmp/testaJDVCU

/tmp/testaJDVCU/node0/regtest/debug.log

2018-03-19 21:38:15 Removing expired txid: a95d04ee7791db82ed2919dcd52d799cb9e38821fa7470ea4bee6c667217aa98
2018-03-19 21:38:15 Removing expired txid: d043dfb7697b08d2f86ac9f73dc460b49a5c4ddbecef0a14bccdbe1abadf72a9

/tmp/testaJDVCU/node1/regtest/debug.log

2018-03-19 21:38:15 Removing expired txid: a95d04ee7791db82ed2919dcd52d799cb9e38821fa7470ea4bee6c667217aa98
2018-03-19 21:38:15 Removing expired txid: d043dfb7697b08d2f86ac9f73dc460b49a5c4ddbecef0a14bccdbe1abadf72a9

@bitcartel bitcartel removed the request for review from arcalinea March 19, 2018 21:58
@bitcartel
Copy link
Contributor Author

Two ACKS so let's merge. @zkbot r+

@zkbot
Copy link
Contributor

zkbot commented Mar 19, 2018

📌 Commit eb13862 has been approved by bitcartel

@zkbot
Copy link
Contributor

zkbot commented Mar 19, 2018

⌛ Testing commit eb13862 with merge 70e2522...

zkbot added a commit that referenced this pull request Mar 19, 2018
@zkbot
Auto merge of #3090 - bitcartel:3084_log_expired_txid, r=bitcartel
70e2522 
Closes #3084.  Log txid when removing expired transactions from mempool.
@zkbot
Copy link
Contributor

zkbot commented Mar 19, 2018

☀️ Test successful - pr-merge
Approved by: bitcartel
Pushing 70e2522 to master...

@zkbot zkbot merged commit eb13862 into zcash:master Mar 19, 2018
Network Upgrade 0 automation moved this from Work Queue to Complete Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@str4d str4d str4d approved these changes

@mdr0id mdr0id Awaiting requested review from mdr0id

Assignees

@bitcartel bitcartel

Labels
A-logging Area: Logging Z-NU0 wishlist
Projects
No open projects
Network Upgrade 0
  
Complete
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bitcartel @mdr0id @zkbot @str4d