Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Part of #2966, extending Sprout tests to other epochs #3157

Merged
merged 1 commit into from
Apr 15, 2018
Merged

Part of #2966, extending Sprout tests to other epochs #3157

merged 1 commit into from
Apr 15, 2018

Conversation

bitcartel
Copy link
Contributor

This continues the work started in PR #3109.

@bitcartel bitcartel added A-testing Area: Tests and testing infrastructure NU0-overwinter Network upgrade: Overwinter-specific tasks labels Apr 9, 2018
@bitcartel bitcartel added this to the v1.1.1 milestone Apr 9, 2018
@bitcartel bitcartel self-assigned this Apr 9, 2018
@bitcartel bitcartel requested a review from str4d April 9, 2018 22:59
@bitcartel bitcartel force-pushed the 2966_extend_sprout_tests_part_2 branch from 88a3e50 to 61624ed Compare April 9, 2018 23:17
@bitcartel
Copy link
Contributor Author

@zkbot try

@zkbot
Copy link
Contributor

zkbot commented Apr 9, 2018

⌛ Trying commit 61624ed with merge 95d9656...

zkbot added a commit that referenced this pull request Apr 9, 2018
@zkbot
Auto merge of #3157 - bitcartel:2966_extend_sprout_tests_part_2, r=<try>
95d9656 
Part of #2966, extending Sprout tests to other epochs

This continues the work started in PR #3109.
@zkbot
Copy link
Contributor

zkbot commented Apr 10, 2018

☀️ Test successful - pr-try
State: approved= try=True

str4d
str4d approved these changes Apr 10, 2018
View reviewed changes
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK+cov

@str4d str4d requested a review from charlieok April 10, 2018 18:52
@str4d str4d added this to In Review in Protocol Team Apr 13, 2018
@str4d str4d removed the request for review from charlieok April 14, 2018 21:04
@str4d
Copy link
Contributor

str4d commented Apr 14, 2018

@zkbot r+

@zkbot
Copy link
Contributor

zkbot commented Apr 14, 2018

📌 Commit 61624ed has been approved by str4d

zkbot added a commit that referenced this pull request Apr 14, 2018
@zkbot
Auto merge of #3157 - bitcartel:2966_extend_sprout_tests_part_2, r=str4d
1594c84 
Part of #2966, extending Sprout tests to other epochs

This continues the work started in PR #3109.
@zkbot
Copy link
Contributor

zkbot commented Apr 14, 2018

⌛ Testing commit 61624ed with merge 1594c84...

@zkbot
Copy link
Contributor

zkbot commented Apr 15, 2018

☀️ Test successful - pr-merge
Approved by: str4d
Pushing 1594c84 to master...

Protocol Team automation moved this from In Review to Complete PRs (Ignore) Apr 15, 2018
@zkbot zkbot merged commit 61624ed into zcash:master Apr 15, 2018
@daira daira mentioned this pull request Aug 16, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebfull ebfull ebfull approved these changes

@str4d str4d str4d approved these changes

Assignees

@bitcartel bitcartel

Labels
A-testing Area: Tests and testing infrastructure NU0-overwinter Network upgrade: Overwinter-specific tasks
Projects
None yet
Milestone
v1.1.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bitcartel @zkbot @str4d @ebfull