Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When rewinding, reset pindexBestInvalid if it is pointing to a removed block #3166

Merged
merged 1 commit into from
Apr 12, 2018

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Apr 12, 2018

No description provided.

@str4d str4d added C-bug Category: This is a bug network upgrade management labels Apr 12, 2018
@str4d str4d added this to the v1.1.0 milestone Apr 12, 2018
@str4d str4d requested review from bitcartel and ebfull April 12, 2018 03:49
Copy link
Contributor

@ianamunoz ianamunoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@str4d str4d mentioned this pull request Apr 12, 2018
@str4d
Copy link
Contributor Author

str4d commented Apr 12, 2018

@zkbot r+

@zkbot
Copy link
Contributor

zkbot commented Apr 12, 2018

📌 Commit 39ee63c has been approved by str4d

@zkbot
Copy link
Contributor

zkbot commented Apr 12, 2018

⌛ Testing commit 39ee63c with merge b89b48c...

zkbot added a commit that referenced this pull request Apr 12, 2018
When rewinding, reset pindexBestInvalid if it is pointing to a removed block
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@zkbot
Copy link
Contributor

zkbot commented Apr 12, 2018

☀️ Test successful - pr-merge
Approved by: str4d
Pushing b89b48c to master...

@zkbot zkbot merged commit 39ee63c into zcash:master Apr 12, 2018
@str4d str4d deleted the 3132-reset-pindexbestinvalid branch April 12, 2018 11:07
@bitcartel
Copy link
Contributor

Post-ACK, tested with datadir, error no longer reported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants