New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminate immediately when allocation fails #3193

Merged
merged 4 commits into from May 1, 2018

Conversation

@str4d
Contributor

str4d commented Apr 19, 2018

Backport of bitcoin/bitcoin#9856

Closes #1498.

theuni added some commits Feb 24, 2017

@str4d str4d added this to the v1.1.1 milestone Apr 19, 2018

@str4d str4d requested review from bitcartel and arcalinea Apr 19, 2018

@str4d str4d added this to Implemented — Waiting for ACKs in Zcashd Team Apr 19, 2018

Show outdated Hide outdated src/prevector.h
Show outdated Hide outdated src/prevector.h
Show outdated Hide outdated src/init.cpp

str4d added some commits Apr 23, 2018

Addressed comments.

@mdr0id

mdr0id approved these changes Apr 26, 2018

Tested ACK:

Sanity checked calling sequence via

char* new_indirect  = NULL;
➜  src git:(b9856-badalloc-terminate) ✗ ./zcashd                
Error: Out of memory. Terminating.
terminate called without an active exception
[1]    60500 abort (core dumped)  ./zcashd

Otherwise performs as expected with suggested implementation

@bitcartel

This comment has been minimized.

Show comment
Hide comment
@bitcartel

bitcartel May 1, 2018

Contributor

ACK. Ran same test as above. Results:

Error: Out of memory. Terminating.
terminate called without an active exception
Aborted (core dumped)

Contributor

bitcartel commented May 1, 2018

ACK. Ran same test as above. Results:

Error: Out of memory. Terminating.
terminate called without an active exception
Aborted (core dumped)

@bitcartel

This comment has been minimized.

Show comment
Hide comment
@bitcartel

bitcartel May 1, 2018

Contributor

@zkbot r+

Contributor

bitcartel commented May 1, 2018

@zkbot r+

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot May 1, 2018

Contributor

📌 Commit aeb089e has been approved by bitcartel

Contributor

zkbot commented May 1, 2018

📌 Commit aeb089e has been approved by bitcartel

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot May 1, 2018

Contributor

⌛️ Testing commit aeb089e with merge 1fd3207...

Contributor

zkbot commented May 1, 2018

⌛️ Testing commit aeb089e with merge 1fd3207...

zkbot added a commit that referenced this pull request May 1, 2018

Auto merge of #3193 - str4d:b9856-badalloc-terminate, r=bitcartel
Terminate immediately when allocation fails

Backport of bitcoin/bitcoin#9856

Closes #1498.
@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot May 1, 2018

Contributor

💔 Test failed - pr-merge

Contributor

zkbot commented May 1, 2018

💔 Test failed - pr-merge

@str4d

This comment has been minimized.

Show comment
Hide comment
@str4d

str4d May 1, 2018

Contributor
Contributor

str4d commented May 1, 2018

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot May 1, 2018

Contributor

⌛️ Testing commit aeb089e with merge 23f8b30...

Contributor

zkbot commented May 1, 2018

⌛️ Testing commit aeb089e with merge 23f8b30...

zkbot added a commit that referenced this pull request May 1, 2018

Auto merge of #3193 - str4d:b9856-badalloc-terminate, r=bitcartel
Terminate immediately when allocation fails

Backport of bitcoin/bitcoin#9856

Closes #1498.

@str4d str4d removed the request for review from arcalinea May 1, 2018

@zkbot

This comment has been minimized.

Show comment
Hide comment
@zkbot

zkbot May 1, 2018

Contributor

☀️ Test successful - pr-merge
Approved by: bitcartel
Pushing 23f8b30 to master...

Contributor

zkbot commented May 1, 2018

☀️ Test successful - pr-merge
Approved by: bitcartel
Pushing 23f8b30 to master...

Zcashd Team automation moved this from In Review to Released (Merged in Master) May 1, 2018

@zkbot zkbot merged commit aeb089e into zcash:master May 1, 2018

1 check passed

homu Test successful
Details

@zkbot zkbot referenced this pull request May 1, 2018

Open

Misc upstream PRs #2390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment