Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more checkpoints, up to the 1.1.0 release #3246

Merged
merged 2 commits into from Aug 1, 2018

Conversation

str4d
Copy link
Contributor

@str4d str4d commented May 7, 2018

No description provided.

@str4d str4d added I-performance Problems and improvements with respect to performance A-consensus Area: Consensus rules labels May 7, 2018
@str4d str4d added this to the v1.1.1 milestone May 7, 2018
@str4d
Copy link
Contributor Author

str4d commented May 7, 2018

It would be nice if we had a benchmark of IBD time before this was merged, so we could see the effect.

@str4d str4d added this to In Review in Arborist Team May 14, 2018
@str4d str4d moved this from In Review to Blocked in Arborist Team May 14, 2018
@str4d str4d modified the milestones: v1.1.1, v2.0.0 May 25, 2018
@bitcartel bitcartel moved this from Blocked to In Review in Arborist Team May 30, 2018
@bitcartel bitcartel moved this from In Review to Blocked in Arborist Team May 30, 2018
@str4d str4d modified the milestones: v1.1.2, v2.0.0 Jul 2, 2018
@daira
Copy link
Contributor

daira commented Jul 24, 2018

We should change this to add further checkpoints following Overwinter activation.

@daira daira moved this from Blocked to In Progress in Arborist Team Jul 24, 2018
@bitcartel bitcartel moved this from In Progress to Review Backlog in Arborist Team Jul 25, 2018
(133337, uint256S("0x0000000002776ccfaf06cc19857accf3e20c01965282f916b8a886e3e4a05be9"))
(180000, uint256S("0x000000001205b742eac4a1b3959635bdf8aeada078d6a996df89740f7b54351d"))
(222222, uint256S("0x000000000cafb9e56445a6cabc8057b57ee6fcc709e7adbfa195e5c7fac61343"))
(270000, uint256S("0x000000000a9357513c894fb91e42e116c385da39d037c1ddb217fdd0637401f1"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong blockhash: 0x00...a93575... is for block 270001.

Block 270000 is below:

2018-07-17 08:48:24 UpdateTip: new best=00000000025c1cfa0258e33ab050aaa9338a3d4aaa3eb41defefc887779a9729 height=270000 log2_work=52.732642 tx=2415465 date=2018-02-10 18:43:00 progress=0.832105 cache=6.9MiB(325tx)

@str4d
Copy link
Contributor Author

str4d commented Jul 30, 2018

Fixed the block hash (after confirming that I saw the same hash as @bitcartel).

@str4d str4d moved this from Review Backlog to In Review in Arborist Team Aug 1, 2018
@daira daira dismissed bitcartel’s stale review August 1, 2018 10:12

Block hash is fixed.

Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked using https://zcash.blockexplorer.com that:

  • the heights match the added blocks with the given hashes;
  • the added blocks all satisfy the "no blocks before with a timestamp after, none after with timestamp before" criterion, for a few blocks before and after;
  • the timestamp of block 304600 is correct.

I did not check the total number of transactions or the estimated transactions per day; nor did I check the criterion "Contains no strange transactions" (because I don't know what that would mean).

utACK.

@bitcartel
Copy link
Contributor

@zkbot r+

@zkbot
Copy link
Contributor

zkbot commented Aug 1, 2018

📌 Commit 3f4ad59 has been approved by bitcartel

@bitcartel bitcartel moved this from In Review to Released (Merged in Master) in Arborist Team Aug 1, 2018
@zkbot
Copy link
Contributor

zkbot commented Aug 1, 2018

⌛ Testing commit 3f4ad59 with merge 0361f78...

zkbot added a commit that referenced this pull request Aug 1, 2018
Add some more checkpoints, up to the 1.1.0 release
@zkbot
Copy link
Contributor

zkbot commented Aug 1, 2018

☀️ Test successful - pr-merge
Approved by: bitcartel
Pushing 0361f78 to master...

@zkbot zkbot merged commit 3f4ad59 into zcash:master Aug 1, 2018
@str4d str4d deleted the checkpoint-304600 branch March 10, 2020 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Area: Consensus rules I-performance Problems and improvements with respect to performance
Projects
Arborist Team
  
Released (Merged in Master)
Development

Successfully merging this pull request may close these issues.

None yet

4 participants