New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some more checkpoints, up to the 1.1.0 release #3246
Conversation
It would be nice if we had a benchmark of IBD time before this was merged, so we could see the effect. |
We should change this to add further checkpoints following Overwinter activation. |
src/chainparams.cpp
Outdated
(133337, uint256S("0x0000000002776ccfaf06cc19857accf3e20c01965282f916b8a886e3e4a05be9")) | ||
(180000, uint256S("0x000000001205b742eac4a1b3959635bdf8aeada078d6a996df89740f7b54351d")) | ||
(222222, uint256S("0x000000000cafb9e56445a6cabc8057b57ee6fcc709e7adbfa195e5c7fac61343")) | ||
(270000, uint256S("0x000000000a9357513c894fb91e42e116c385da39d037c1ddb217fdd0637401f1")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong blockhash: 0x00...a93575... is for block 270001.
Block 270000 is below:
2018-07-17 08:48:24 UpdateTip: new best=00000000025c1cfa0258e33ab050aaa9338a3d4aaa3eb41defefc887779a9729 height=270000 log2_work=52.732642 tx=2415465 date=2018-02-10 18:43:00 progress=0.832105 cache=6.9MiB(325tx)
Fixed the block hash (after confirming that I saw the same hash as @bitcartel). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked using https://zcash.blockexplorer.com that:
- the heights match the added blocks with the given hashes;
- the added blocks all satisfy the "no blocks before with a timestamp after, none after with timestamp before" criterion, for a few blocks before and after;
- the timestamp of block 304600 is correct.
I did not check the total number of transactions or the estimated transactions per day; nor did I check the criterion "Contains no strange transactions" (because I don't know what that would mean).
utACK.
@zkbot r+ |
📌 Commit 3f4ad59 has been approved by |
Add some more checkpoints, up to the 1.1.0 release
No description provided.