Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to use the official Sapling parameters #3448

Merged
merged 1 commit into from Aug 7, 2018
Merged

Switch to use the official Sapling parameters #3448

merged 1 commit into from Aug 7, 2018

Conversation

ebfull
Copy link
Contributor

@ebfull ebfull commented Aug 4, 2018

No description provided.

str4d
str4d approved these changes Aug 7, 2018
View reviewed changes
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. I ran the updated fetch-params.sh script (which verified the SHA256 hashes), and then manually ran b2sum to check the BLAKE2b hashes.

@str4d str4d added this to the v2.0.0 milestone Aug 7, 2018
@str4d str4d added zkSNARK Parameter Deployment NU1-sapling Network upgrade: Sapling-specific tasks labels Aug 7, 2018
@str4d str4d added this to In Review in Arborist Team Aug 7, 2018
@bitcartel
Copy link
Contributor

@zkbot r+

@zkbot
Copy link
Contributor

zkbot commented Aug 7, 2018

📌 Commit 198dfd3 has been approved by bitcartel

@zkbot
Copy link
Contributor

zkbot commented Aug 7, 2018

⌛ Testing commit 198dfd3 with merge 0c5733f...

zkbot added a commit that referenced this pull request Aug 7, 2018
@zkbot
Auto merge of #3448 - ebfull:sapling-params, r=bitcartel
0c5733f 
Switch to use the official Sapling parameters
daira
daira approved these changes Aug 7, 2018
View reviewed changes
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@zkbot
Copy link
Contributor

zkbot commented Aug 7, 2018

☀️ Test successful - pr-merge
Approved by: bitcartel
Pushing 0c5733f to master...

@zkbot zkbot merged commit 198dfd3 into zcash:master Aug 7, 2018
Arborist Team automation moved this from In Review to Released (Merged in Master) Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitcartel bitcartel bitcartel approved these changes

@daira daira daira approved these changes

@str4d str4d str4d approved these changes

Assignees
No one assigned
Labels
NU1-sapling Network upgrade: Sapling-specific tasks zkSNARK Parameter Deployment
Projects
Arborist Team
  
Released (Merged in Master)
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ebfull @bitcartel @zkbot @daira @str4d