Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CheckProofOfWork errors from logs #4165

Merged
merged 1 commit into from Dec 3, 2019
Merged

Conversation

oxarbitrage
Copy link
Contributor

To fix #4029 bitcoin patch(bitcoin/bitcoin#7459) was ported.

@Eirik0 Eirik0 added the C-community-contribution Category: A contribution from the community! label Oct 24, 2019
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. I checked this corresponds to the upstream PR with only trivial changes.

@daira daira added this to the v2.1.1 milestone Oct 25, 2019
@ebfull
Copy link
Contributor

ebfull commented Nov 13, 2019

utACK

@str4d
Copy link
Contributor

str4d commented Nov 27, 2019

Note: in future please cherry-pick commits from upstream (i.e. including all commit metadata) where possible, for more accurate attribution. I'm not going to block this PR on doing so.

@oxarbitrage
Copy link
Contributor Author

oxarbitrage commented Nov 27, 2019

Got it, will do that. thanks @str4d

In addition to the attribution, it easier for the reviewer as well, my mistake.

@mdr0id
Copy link
Contributor

mdr0id commented Dec 3, 2019

@zkbot r+

@zkbot
Copy link
Contributor

zkbot commented Dec 3, 2019

📌 Commit 0eec096 has been approved by mdr0id

@zkbot
Copy link
Contributor

zkbot commented Dec 3, 2019

⌛ Testing commit 0eec096 with merge 173d6a7...

zkbot added a commit that referenced this pull request Dec 3, 2019
Remove CheckProofOfWork errors from logs

To fix #4029 bitcoin patch(bitcoin/bitcoin#7459) was ported.
@zkbot
Copy link
Contributor

zkbot commented Dec 3, 2019

☀️ Test successful - pr-merge
Approved by: mdr0id
Pushing 173d6a7 to master...

@zkbot zkbot merged commit 0eec096 into zcash:master Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-community-contribution Category: A contribution from the community!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

annoying error message flooding the logs
7 participants