Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update libsodium to v1.0.18 #4239

Closed
wants to merge 2 commits into from
Closed

update libsodium to v1.0.18 #4239

wants to merge 2 commits into from

Conversation

ca333
Copy link
Contributor

@ca333 ca333 commented Nov 25, 2019

fixes #4238

@ca333
Copy link
Contributor Author

ca333 commented Nov 25, 2019

We updated libsodium to 1.0.18 in Komodo and tested it with our codebase to ensure backwards compatibility - i just replicated KomodoPlatform@5bb0bdf in 934cdad

@ca333 ca333 changed the title update libsodium fetch-URL update libsodium to v1.0.18 Nov 25, 2019
@ca333 ca333 mentioned this pull request Nov 25, 2019
Closed
@str4d str4d added the C-community-contribution Category: A contribution from the community! label Nov 26, 2019
@daira
Copy link
Contributor

daira commented Nov 27, 2019 •
edited

Due to it affecting cryptographic code and the risk of unintended consensus changes, this requires 3 reviews (including of the relevant code in libsodium); at least 2 from ECC engineers.

@r3ld3v r3ld3v added this to the Core Sprint 2020-03 milestone Jan 13, 2020
@zkbot
Copy link
Contributor

zkbot commented Jan 14, 2020

☔ The latest upstream changes (presumably #4296) made this pull request unmergeable. Please resolve the merge conflicts.

@str4d str4d added the S-committed Status: Planned work in a sprint label Jan 22, 2020
@str4d str4d removed this from the Core Sprint 2020-03 milestone Jan 27, 2020
@str4d str4d mentioned this pull request Feb 18, 2020
Merged
@str4d
Copy link
Contributor

str4d commented Feb 18, 2020

Superceded by #4359.

@str4d str4d closed this Feb 18, 2020
zkbot added a commit that referenced this pull request Mar 10, 2020
@zkbot
Auto merge of #4359 - str4d:2872-upgrade-libsodium, r=str4d
dcd3614 
Upgrade libsodium to 1.0.18

Includes patches that maintain consensus compatibility with libsodium 1.0.15 for Ed25519 pubkey and signature validation.

Replaces #4239. Closes #2872.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daira daira Awaiting requested review from daira

@defuse defuse Awaiting requested review from defuse

@ebfull ebfull Awaiting requested review from ebfull

@str4d str4d Awaiting requested review from str4d

Assignees
No one assigned
Labels
C-community-contribution Category: A contribution from the community! S-committed Status: Planned work in a sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

libsodium 1.0.15 deprecated
5 participants
@ca333 @daira @zkbot @str4d @r3ld3v