Backport of bitcoin/bitcoin#8020 #4979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is ~1.7x slower than the Lookup3-of-Xor-with-salt construct we were using before, but it is a primitive designed for exactly this. Zcash: Propagate CCoinsKeyHasher -> SaltedTxidHasher changes to where we've used CCoinsKeyHasher outside of its original scope.
Zcash: conflicts resolved against 957e5d2
This was referenced Feb 11, 2021
|
How does this conflict? 5490 from upstream was merged before we forked. |
str4d
approved these changes
Feb 15, 2021
There was a problem hiding this comment.
utACK. I checked the SipHash-2-4 implementation against the reference implementation.
str4d
added
C-upstream-port
|
This does not affect consensus (it alters the hasher used inside maps that are used by consensus, but that only affects the DoS-resistance of those maps, not their consensus behaviour), or risk user funds, and thus only requires one review. @zkbot r+ |
|
📌 Commit cfc4ca1 has been approved by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from bitcoin/bitcoin#8020