Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitcoin 0.12 misc P2P/Net PRs #4994

Merged
merged 9 commits into from Feb 19, 2021
Merged

Bitcoin 0.12 misc P2P/Net PRs #4994

merged 9 commits into from Feb 19, 2021

Commits on Feb 18, 2021

  1. Re-organize -maxconnections option handling

    Zcash: Was "Added -whiteconnections=<n> option" from bitcoin/bitcoin#5288. The
    option was later removed in bitcoin/bitcoin#6374 which we merged in zcash#1258. This
    commit contains the difference between the two.
    Krellan authored and str4d committed Feb 18, 2021
    Copy the full SHA
    d3a2f12 View commit details
    Browse the repository at this point in the history
  2. Make limited map actually respect max size

    casey authored and str4d committed Feb 18, 2021
    Copy the full SHA
    4a51753 View commit details
    Browse the repository at this point in the history
  3. Disallow unlimited limited maps

    casey authored and str4d committed Feb 18, 2021
    Copy the full SHA
    b43fc81 View commit details
    Browse the repository at this point in the history
  4. Add limitedmap test

    casey authored and str4d committed Feb 18, 2021
    Copy the full SHA
    63a214a View commit details
    Browse the repository at this point in the history
  5. timedata: Prevent warning overkill

    The "please check your computer's data and time" message when the clock
    deviates from the network currently generates an overkill of messages:
    
        orion@lethe:~/bitcoin$ src/bitcoind
        Warning: Warning: Please check that your computer's date and time are correct! If your clock is wrong Bitcoin Core will not work properly.
    
    In the log:
    
        2015-09-27 16:24:13 *** Warning: Please check that your computer's date and time are correct! If your clock is wrong Bitcoin Core will not work properly.
        2015-09-27 16:24:13 Warning: Warning: Please check that your computer's date and time are correct! If your clock is wrong Bitcoin Core will not work properly.
    
    Remove one level of 'Warning:' and reduce to one log message.
    laanwj authored and str4d committed Feb 18, 2021
    Copy the full SHA
    f2c38a5 View commit details
    Browse the repository at this point in the history
  6. doc: add comment explaining initial header request

    Add a comment that explains why the initial "getheader" requests are
    made starting from the block preceding the currently best one.
    
    Thanks to sdaftuar for the explanation!
    domob1812 authored and str4d committed Feb 18, 2021
    Copy the full SHA
    d620798 View commit details
    Browse the repository at this point in the history
  7. Always allow getheaders from whitelisted peers

    Process `getheaders` messages from whitelisted peers even if we are in
    initial block download. Whitelisted peers can always use a node as a
    block source.
    
    Also log a debug message when the request is ignored, for
    troubleshooting.
    
    Fixes #6971.
    laanwj authored and str4d committed Feb 18, 2021
    Copy the full SHA
    fee9309 View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    a3bc3c3 View commit details
    Browse the repository at this point in the history
  9. Disconnect on mempool requests from peers when over the upload limit.

    Mempool requests use a fair amount of bandwidth when the mempool is large,
     disconnecting peers using them follows the same logic as disconnecting
     peers fetching historical blocks.
    gmaxwell authored and str4d committed Feb 18, 2021
    Copy the full SHA
    39cb786 View commit details
    Browse the repository at this point in the history