Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: Split DNS resolving functionality out of net structures #5005

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/bips.md
Expand Up @@ -2,3 +2,4 @@ BIPs that are implemented by Zcash (up-to-date up to **v1.1.0**):

* Numerous historic BIPs were present in **v1.0.0** at launch; see [the protocol spec](https://github.com/zcash/zips/blob/master/protocol/protocol.pdf) for details.
* [`BIP 111`](https://github.com/bitcoin/bips/blob/master/bip-0111.mediawiki): `NODE_BLOOM` service bit added, but only enforced for peer versions `>=170004` as of **v1.1.0** ([PR #2814](https://github.com/zcash/zcash/pull/2814)).
* [`BIP 130`](https://github.com/bitcoin/bips/blob/master/bip-0130.mediawiki): direct headers announcement is negotiated with peer versions `>=170012` as of **v1.1.1** ([PR ????](https://github.com/zcash/zcash/pull/????)).
9 changes: 9 additions & 0 deletions doc/release-notes.md
Expand Up @@ -25,3 +25,12 @@ calculating the target.

A more detailed documentation about keeping traffic low can be found in
[/doc/reducetraffic.md](/doc/reducetraffic.md).

Direct headers announcement (BIP 130)
-------------------------------------

Between compatible peers, BIP 130 direct headers announcement is used. This
means that blocks are advertized by announcing their headers directly, instead
of just announcing the hash. In a reorganization, all new headers are sent,
instead of just the new tip. This can often prevent an extra roundtrip before
the actual block is downloaded.
1 change: 1 addition & 0 deletions qa/pull-tester/rpc-tests.py
Expand Up @@ -58,6 +58,7 @@
'wallet_persistence.py',
'wallet_listnotes.py',
# vv Tests less than 60s vv
'sendheaders.py',
'fundrawtransaction.py',
'reorg_limit.py',
'mempool_limit.py',
Expand Down
6 changes: 3 additions & 3 deletions qa/rpc-tests/p2p_nu_peer_management.py
Expand Up @@ -70,11 +70,11 @@ def run_test(self):
nodes = []
for x in range(10):
nodes.append(NodeConn('127.0.0.1', p2p_port(0), self.nodes[0],
test, "regtest", SPROUT_PROTO_VERSION))
test, "regtest", 1, SPROUT_PROTO_VERSION))
nodes.append(NodeConn('127.0.0.1', p2p_port(0), self.nodes[0],
test, "regtest", OVERWINTER_PROTO_VERSION))
test, "regtest", 1, OVERWINTER_PROTO_VERSION))
nodes.append(NodeConn('127.0.0.1', p2p_port(0), self.nodes[0],
test, "regtest", SAPLING_PROTO_VERSION))
test, "regtest", 1, SAPLING_PROTO_VERSION))

# Start up network handling in another thread
NetworkThread().start()
Expand Down