Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v4.5.1-1 #5349

Merged
merged 4 commits into from Oct 8, 2021
Merged

Release v4.5.1-1 #5349

merged 4 commits into from Oct 8, 2021

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Oct 8, 2021

No description provided.

@str4d str4d added the C-release Category: This is an issue corresponding to the creation of a specific release. label Oct 8, 2021
@str4d str4d added this to the Core Sprint 2021-40 milestone Oct 8, 2021
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK modulo trivial suggestion.

by the source of the address, including both those addresses generated
by the wallet and those associated with imported viewing or spending
keys. This provides functionality that replaces and subsumes the
previously-removed `getaddressesbyaccount` method.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
previously-removed `getaddressesbyaccount` method.
previously removed `getaddressesbyaccount` method.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can fix this in post (Tekton is now running on this PR, and I don't want to disturb it).

@mdr0id mdr0id added the safe-to-build Used to send PR to prod CI environment label Oct 8, 2021
@str4d str4d merged commit 3ac39a5 into zcash:hotfix-v4.5.1-1 Oct 8, 2021
@str4d str4d deleted the release-v4.5.1-1 branch October 8, 2021 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-release Category: This is an issue corresponding to the creation of a specific release. safe-to-build Used to send PR to prod CI environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants