Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start with an empty banlist if -reindex is set #5743

Merged
merged 1 commit into from Mar 25, 2022
Merged

Start with an empty banlist if -reindex is set #5743

merged 1 commit into from Mar 25, 2022

Conversation

daira
Copy link
Contributor

@daira daira commented Mar 25, 2022

fixes #5739

@daira
Start with an empty banlist if -reindex is set. fixes zcash#5739
50d4be1 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
@daira daira added the A-networking Area: Networking code label Mar 25, 2022
@daira daira added this to the Core Sprint 2022-10 milestone Mar 25, 2022
str4d
str4d approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK (based on how this duplicates the behaviour of the "invalid or missing banlist" case.

@daira
Copy link
Contributor Author

daira commented Mar 25, 2022

I manually tested this as follows:

  • start a regtest node without the fix
  • add a ban entry using zcash-cli setban $IP add
  • verify that the entry is listed by zcash-cli listbanned
  • shut down and restart the node
  • verify that the entry is still listed by zcash-cli listbanned
  • switch to the fix branch, rebuild, and restart the node (with the same datadir)
  • verify that the entry is still listed by zcash-cli listbanned
  • shut down and restart the node using -reindex -printtoconsole
  • verify that the log prints Clearing banlist.dat for reindex
  • verify that the entry is not listed by zcash-cli listbanned
  • shut down the node and restart without -reindex
  • verify that the entry is still not listed

@daira
Copy link
Contributor Author

daira commented Mar 25, 2022 •
edited

The CI failure for Ubuntu 20.04 (in feature_zip239.py) is unrelated; please admin-merge.

@str4d str4d mentioned this pull request Mar 25, 2022
Open
@mdr0id mdr0id merged commit 4a9bd59 into zcash:master Mar 25, 2022
@daira daira deleted the no-banlist-on-reindex branch March 25, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@str4d str4d str4d approved these changes

Assignees
No one assigned
Labels
A-networking Area: Networking code
Projects
None yet
Milestone
Release 4.7.0
Development

Successfully merging this pull request may close these issues.

Start from an empty banlist when running with -reindex set
3 participants
@daira @str4d @mdr0id