Ratchet feature deprecation #6282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str4d
force-pushed
the
ratchet-feature-deprecation
branch
from
0f8c293
to
00e0340
Compare
str4d
force-pushed
the
ratchet-feature-deprecation
branch
from
00e0340
to
9b6694a
Compare
The RPC method handler is left in as a tombstone, to redirect callers to the replacement method (as this is an upstream Bitcoin Core RPC method that users may expect to be present).
str4d
force-pushed
the
ratchet-feature-deprecation
branch
from
9b6694a
to
cbaf6b6
Compare
str4d
force-pushed
the
ratchet-feature-deprecation
branch
from
cbaf6b6
to
6ca3648
Compare
str4d
force-pushed
the
ratchet-feature-deprecation
branch
from
6ca3648
to
1671e40
Compare
str4d
force-pushed
the
ratchet-feature-deprecation
branch
from
1671e40
to
12ca9c9
Compare
str4d
force-pushed
the
ratchet-feature-deprecation
branch
from
12ca9c9
to
1de496f
Compare
str4d
added
safe-to-build
This was referenced Jan 5, 2023
This was referenced Jan 5, 2023
daira
reviewed
Jan 5, 2023
daira
reviewed
Jan 5, 2023
daira
reviewed
Jan 5, 2023
daira
reviewed
Jan 5, 2023
daira
reviewed
Jan 5, 2023
daira
reviewed
Jan 5, 2023
daira
reviewed
Jan 5, 2023
daira
reviewed
Jan 5, 2023
| BASE_ARGS = [ | ||
| '-allowdeprecated=z_getnewaddress', | ||
| '-allowdeprecated=z_getbalance', | ||
| ] | ||
| TURNSTILE_ARGS = ['-experimentalfeatures', | ||
| '-developersetpoolsizezero'] |
There was a problem hiding this comment.
Nit: use the same indentation as for BASE_ARGS.
daira
reviewed
Jan 5, 2023
daira
reviewed
Jan 5, 2023
daira
reviewed
Jan 5, 2023
daira
reviewed
Jan 5, 2023
daira
previously approved these changes
Jan 5, 2023
These features were deprecated at least 3 minor releases ago. I found one mistake which was that `z_validateaddress` had not been placed behind the `addrtype` deprecated feature; this has been fixed.
str4d
force-pushed
the
ratchet-feature-deprecation
branch
from
1de496f
to
5cc15a8
Compare
|
Force-pushed to address @daira's comments. |
|
Post-hoc ACK for the changes since my last review. |
str4d
added a commit
to str4d/zcash
that referenced
this pull request
Mar 13, 2023
The deprecated feature was originally only applied to wallet code, but in zcash#6282 it was extended to a missing case in non-wallet code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1555.
Closes #5513.
Closes #6318.