-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let 'plain' option actually produce plain output. #2
Conversation
Let 'plain' option actually produce plain output.
Thanks mate! Really appreciate your help! |
Always happy to help! |
Hmmm... this |
Did you try including the If you don't have the time, I can try it myself, of course. :) |
Hey Yannick! I've added you to the GitHub so free to push into the lib. I'm a bit behind on work atm so any help is greatly appreciated :) On 05/10/2013, at 23:10, Yannick Scherer notifications@github.com wrote:
|
Thank you very much! I implemented basic HTML escaping in this commit. Since this is not the most critical of issues I'll not merge into master until you've reviewed the changes. Good luck with your work and have a nice day! |
Btw. Off topic. Is there a way for rewrite-clj to output the line number of the element it is currently on. I've seen it there when the parser comes across an error but i'm not sure of the function call that does this. This will be very useful for tagging code in the readmes. On 06/10/2013, at 0:42, Yannick Scherer notifications@github.com wrote:
|
Hey Yannick! I've had a look and it's good to commit. It's really good to have another on the code. Luckily for me, you're also more careful with details than I am :) On 06/10/2013, at 0:42, Yannick Scherer notifications@github.com wrote:
|
Am I though? (Looking at you, namespaced keywords...)
The information is there at parsing time but the only way to generate it afterwards (currently) is by counting the
Very well, merging initiated. :) |
Hahaha... Well you did get the rest of the language :) I tried a number of parsers before rewrite-clj - they were all too complicated. I even tried to write my own instaparser and it was the slowest parser I had ever seen... On 07/10/2013, at 18:23, Yannick Scherer notifications@github.com wrote:
|
As discussed in #1, this pull request fixes the handling of the command line option
plain
(and the subsequent use of the affected var*plain*
). I'll have a look at escaping the contents of the<pre>
blocks if you want to. Should be possible with something like:That would remove most problematic cases, I guess.