fix check for binary root ownership #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
501 is often, but not always, the uid of the user on OS X. For instance in our corp environment, our uid is the same as our active directory id. This new check should be more reliable, as 0 is always the uid of the root user.
|
@codekitchen Thanks PR!! I tested later, and will merge. |
zchee
added a commit
that referenced
this pull request
Mar 10, 2016
fix check for binary root ownership
|
@codekitchen Merged. Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
501 is often, but not always, the uid of the user on OS X. For instance in our corp environment, our uid is the same as our active directory id. This new check should be more reliable, as 0 is always the uid of the root user.