Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent a panic in cty.Type.Equals(Type) when t.typeImpl is nil #44

Closed
wants to merge 2 commits into from

Conversation

azr
Copy link
Contributor

@azr azr commented Feb 14, 2020

Hello there this closes #43.

I'm looking for an acceptable place to tests this. found one

@codecov
Copy link

codecov bot commented Feb 14, 2020

Codecov Report

Merging #44 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
+ Coverage   76.08%   76.15%   +0.06%     
==========================================
  Files          77       77              
  Lines        6172     6172              
==========================================
+ Hits         4696     4700       +4     
+ Misses       1060     1057       -3     
+ Partials      416      415       -1
Impacted Files Coverage Δ
cty/type.go 78.94% <100%> (+5.26%) ⬆️
cty/convert/compare_types.go 100% <0%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c282fd1...c7964b1. Read the comment docs.

@azr
Copy link
Contributor Author

azr commented Mar 4, 2020

I think this one can be closed then 🙂

@azr azr closed this Mar 4, 2020
@azr azr deleted the fix_43 branch March 4, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Converting cty.NilVal to cty.String panics
1 participant