convert: Fix panic: heterogeneous tuple with null #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tuples with elements of different types can be converted to homogeneous
collections (sets or lists), so long as their elements are unifiable.
For example:
list("a", "b") // all elements have the same type
list("a", 5) // "a" and 5 can be unified to string
list("a", 5, null) // null is a valid value for string
However, tuples with elements which are not unifiable cannot be
converted to homogeneous collections:
list(["a"], "b") // no common type for list(string) and string
This commit fixes a panic for this failure case, when the tuple contains
both non-unifiable types and a null value:
list(["a"], "b", null) // should not panic
The null value was causing the unification process to result in a list
or set of dynamic type, which causes the conversion functions to pass
through the original value. This meant that in the final conversion
step, we would attempt to construct a list or set of different values,
which panics.
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
+ Coverage 70.54% 70.60% +0.06%
==========================================
Files 79 79
Lines 7153 7161 +8
==========================================
+ Hits 5046 5056 +10
+ Misses 1664 1662 -2
Partials 443 443
Continue to review full report at Codecov.
|
mildwonkey
approved these changes
Jun 4, 2020
| @@ -156,34 +156,45 @@ func conversionCollectionToMap(ety cty.Type, conv conversion) conversion { | |||
| // given tuple type and return a set of the given element type. | |||
| // | |||
| // Will panic if the given tupleType isn't actually a tuple type. | |||
| func conversionTupleToSet(tupleType cty.Type, listEty cty.Type, unsafe bool) conversion { | |||
| func conversionTupleToSet(tupleType cty.Type, setEty cty.Type, unsafe bool) conversion { | |||
apparentlymart
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tuples with elements of different types can be converted to homogeneous collections (sets or lists), so long as their elements are unifiable. For example:
However, tuples with elements which are not unifiable cannot be converted to homogeneous collections:
This commit fixes a panic for this failure case, when the tuple contains both non-unifiable types and a null value:
The null value was causing the unification process to result in a list or set of dynamic type, which causes the conversion functions to pass through the original value. This meant that in the final conversion step, we would attempt to construct a list or set of different values, which panics.
Fixes hashicorp/terraform#24377