Ensure splitDateFormat() does not try to look for more bytes when we are at EOF #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
==========================================
+ Coverage 70.05% 70.09% +0.04%
==========================================
Files 79 79
Lines 6531 6534 +3
==========================================
+ Hits 4575 4580 +5
+ Misses 1515 1514 -1
+ Partials 441 440 -1
Continue to review full report at Codecov.
|
|
Thanks @OwenTuz! This makes sense to me and I'm going to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Terraform bug hashicorp/terraform#26356
I haven't raised a corresponding issue here, it just seemed like duplication of effort - hope that's ok.
It's end of day here and I'm AFK tomorrow so if there are any issues or changes requested I will be able to look on Friday.