Cleanups and fixups

[azilber]

Changed Bitcoin -> Zcoin verbiage in help texts, and error/info messages.
Omni message should be Exodus.

[ultimaweapon]

Thanks for contribution! Could you please fix the test failed? Here is the logs:

test/crypto_tests.cpp(33): error in "sha256_testvectors": check hash == out failed
test/crypto_tests.cpp(46): error in "sha256_testvectors": check hash == out failed
test/crypto_tests.cpp(46): error in "sha256_testvectors": check hash == out failed
test/crypto_tests.cpp(46): error in "sha256_testvectors": check hash == out failed
test/crypto_tests.cpp(46): error in "sha256_testvectors": check hash == out failed
test/crypto_tests.cpp(46): error in "sha256_testvectors": check hash == out failed
test/crypto_tests.cpp(46): error in "sha256_testvectors": check hash == out failed
test/crypto_tests.cpp(46): error in "sha256_testvectors": check hash == out failed
test/crypto_tests.cpp(46): error in "sha256_testvectors": check hash == out failed
test/crypto_tests.cpp(46): error in "sha256_testvectors": check hash == out failed
test/crypto_tests.cpp(46): error in "sha256_testvectors": check hash == out failed
test/crypto_tests.cpp(46): error in "sha256_testvectors": check hash == out failed
test/crypto_tests.cpp(46): error in "sha256_testvectors": check hash == out failed
test/crypto_tests.cpp(46): error in "sha256_testvectors": check hash == out failed
test/crypto_tests.cpp(46): error in "sha256_testvectors": check hash == out failed
test/crypto_tests.cpp(46): error in "sha256_testvectors": check hash == out failed
test/crypto_tests.cpp(50): error in "sha256_testvectors": check hash == out failed

[azilber]

I'm unable to get tests to run on OSX. Keep getting this error:

$ ./src/test/test_bitcoin --log_level=all --run_test=crypto_tests --color_output=0
unknown location:0: fatal error: in "Test setup": boost::runtime::access_to_missing_argument: There is no argument provided for parameter color_output

*** No errors detected
Test setup error: 

Even when following this: https://stackoverflow.com/questions/39171467/there-is-no-argument-provided-for-parameter-color-output-with-boost-test-and-cte

[azilber]

Opened issue 517 regarding not being able to run the test suite. Attempted that on vanilla code.

[ultimaweapon]

For text I think it should be Zcoin instead of zcoin. @reubenyap what do you think?

[catchingknives]

I agree

[azilber]

I also agree, it should always be Zcoin as that seems to be what's most actively used. I've used "zcoin" where it used to be "bitcoin" before, and "Zcoin" where "Bitcoin" was specified, matching case.

So to confirm, you want each, and every occurrence of "zcoin" to be "Zcoin"?

[ultimaweapon]

@azilber Yes for display string change to Zcoin. For other string it depend of what is it (e.g. if it is path name for data directory it should be lower cases).

[azilber]

@ultimaweapon I've changed all the user-facing text I could find, and most of the comments as well. I left out the obvious and the ambiguous, as well as (obviously) the command related comments. None of the functions/methods were touched.

[reubenyap]

@azilber So I understand that Bitcoin refers to the network while bitcoin refers to the units, The meaning changes a little depending on the capitalization, did you check whether it's following this ?

[azilber]

@reubenyap No it does not. I have Zcoin (for the network) and Zcoins (for the units). This only relates to user facing info.

For example:
original:
\"fee\" : \"n.nnnnnnnn\", (string) the transaction fee in zcoins\n"

new:
\"fee\" : \"n.nnnnnnnn\", (string) the transaction fee in Zcoins\n"

Then there's stuff like:
"your Zcoins from being stolen by malware infecting your computer."

Those are actually not too many, but at times it can be somewhat ambiguous. I think it's really a matter of preference. Which one do you prefer?

[reubenyap]

@reubenyap No it does not. I have Zcoin (for the network) and Zcoins (for the units). This only relates to user facing info.

For example:
original:
\"fee\" : \"n.nnnnnnnn\", (string) the transaction fee in zcoins\n"

new:
\"fee\" : \"n.nnnnnnnn\", (string) the transaction fee in Zcoins\n"

Then there's stuff like:
"your Zcoins from being stolen by malware infecting your computer."

Those are actually not too many, but at times it can be somewhat ambiguous. I think it's really a matter of preference. Which one do you prefer?

Sorry about the confusion but I think I prefer to keep the same wording to refer to zcoin when you're dealing with the currency and Zcoin when it refers to the project/protocol/network!

Thanks @azilber !

[azilber]

This last commit should do the trick. Please review.

[azilber]

@ultimaweapon There's a few unresolved items, please check.

[ultimaweapon]

@azilber thanks for your fixes! For the message Cannot start zcoin: click-to-pay handler what it mean is it was tried to start handler for zcoin:// URI and it failed.

[azilber]

Ok, this should be the last of them. There might be still some random stragglers, but I think I caught all of the obvious ones.

[thebevrishot]

LGTM, thank you for your contribution.

[a-bezrukov]

Titanic work! Thanks!